Skip to content

Conversation

@inkydragon
Copy link
Member

The macOS-13 based runner images are being deprecated, consider switching to macOS-15 (macos-15-intel) or macOS 15 arm64 (macos-latest) instead. For more details see actions/runner-images#13046

The macOS-13 based runner images are being deprecated, consider switching to macOS-15 (macos-15-intel) or macOS 15 arm64 (macos-latest) instead. For more details see actions/runner-images#13046
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.17%. Comparing base (c733f17) to head (4c08755).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #203   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files           8        8           
  Lines         813      813           
=======================================
  Hits          790      790           
  Misses         23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- remove dup `pull_request:`
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions CI configuration to migrate from the deprecated macos-13 runner to macos-15-intel in response to GitHub's deprecation notice. However, the changes inadvertently remove the pull_request: trigger, which would prevent CI from running on pull requests.

Key Changes:

  • Updates the Intel macOS runner from macos-13 to macos-15-intel
  • Critical Issue: Accidentally removes the pull_request: workflow trigger

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tags: ['*']
pull_request:
workflow_dispatch:
workflow_dispatch:
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull_request: trigger appears to have been inadvertently removed in this change. Based on the diff, this line is being deleted along with the workflow_dispatch line, but only workflow_dispatch is being re-added. This means the CI workflow will no longer run on pull requests, which is likely unintended and would significantly reduce CI coverage.

Please restore the pull_request: trigger to maintain CI execution on pull requests.

Copilot uses AI. Check for mistakes.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pull_request: The PR trigger condition is duplicated. This fixes the indentation issue for the manual trigger

on:
pull_request:
push:

@inkydragon inkydragon merged commit c0e76ef into JuliaMath:master Dec 8, 2025
18 checks passed
@inkydragon inkydragon deleted the ci-macos branch December 8, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant