-
Notifications
You must be signed in to change notification settings - Fork 61
ci: use macos-15-intel
#203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
inkydragon
commented
Dec 8, 2025
The macOS-13 based runner images are being deprecated, consider switching to macOS-15 (macos-15-intel) or macOS 15 arm64 (macos-latest) instead. For more details see actions/runner-images#13046
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #203 +/- ##
=======================================
Coverage 97.17% 97.17%
=======================================
Files 8 8
Lines 813 813
=======================================
Hits 790 790
Misses 23 23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- remove dup `pull_request:`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the GitHub Actions CI configuration to migrate from the deprecated macos-13 runner to macos-15-intel in response to GitHub's deprecation notice. However, the changes inadvertently remove the pull_request: trigger, which would prevent CI from running on pull requests.
Key Changes:
- Updates the Intel macOS runner from
macos-13tomacos-15-intel - Critical Issue: Accidentally removes the
pull_request:workflow trigger
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| tags: ['*'] | ||
| pull_request: | ||
| workflow_dispatch: | ||
| workflow_dispatch: |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull_request: trigger appears to have been inadvertently removed in this change. Based on the diff, this line is being deleted along with the workflow_dispatch line, but only workflow_dispatch is being re-added. This means the CI workflow will no longer run on pull requests, which is likely unintended and would significantly reduce CI coverage.
Please restore the pull_request: trigger to maintain CI execution on pull requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pull_request: The PR trigger condition is duplicated. This fixes the indentation issue for the manual trigger
Combinatorics.jl/.github/workflows/CI.yml
Lines 3 to 5 in c733f17
| on: | |
| pull_request: | |
| push: |