Skip to content

ci: use macos-15-intel #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inkydragon merged 2 commits into from
Dec 8, 2025
Merged

ci: use macos-15-intel #203

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66987c4
ci: use `macos-15-intel`
inkydragon Dec 8, 2025
4c08755
ci: fix CI.yml
inkydragon Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ on:
- master
- main
tags: ['*']
pull_request:
workflow_dispatch:
workflow_dispatch:
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull_request: trigger appears to have been inadvertently removed in this change. Based on the diff, this line is being deleted along with the workflow_dispatch line, but only workflow_dispatch is being re-added. This means the CI workflow will no longer run on pull requests, which is likely unintended and would significantly reduce CI coverage.

Please restore the pull_request: trigger to maintain CI execution on pull requests.

Copilot uses AI. Check for mistakes.
Copy link
Member Author

@inkydragon inkydragon Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pull_request: The PR trigger condition is duplicated. This fixes the indentation issue for the manual trigger

Combinatorics.jl/.github/workflows/CI.yml

Lines 3 to 5 in c733f17

on:
pull_request:
push:


concurrency:
# Skip intermediate builds: always.
Expand Down Expand Up @@ -40,7 +39,7 @@ jobs:
- os: macos-latest
version: '1.0'
include:
- os: macos-13 # Intel
- os: macos-15-intel # Intel
version: '1.0'
steps:
- uses: actions/checkout@v6
Expand Down
Loading