Revert back to the standard form for ccall which supports LazyLibrary improvements #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #318 +/- ##
==========================================
- Coverage 71.50% 69.31% -2.20%
==========================================
Files 5 5
Lines 544 541 -3
==========================================
- Hits 389 375 -14
- Misses 155 166 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… improvements We had initially planned a breaking change design for LazyLibrary, which this package was updated for, but later we realized a better design which allows going back to the original version of this code. The previous form is still very poorly supported in the compiler and was still rather buggy internally. Revert "Replace `__init__` with `OncePerProcess` on supported Julia versions (#316)" This reverts commit dbcb5d2. Revert "Make FFTW relocatable for PackageCompiler" This reverts commit e96270a.
vtjnash
force-pushed
the
jn/lazylib_support
branch
from
9d87f10 to
eda5550
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had initially planned a breaking change design for LazyLibrary,
which this package was updated for, but later we realized a better
design which allows going back to the original version of this code.
The previous form is still very poorly supported in the compiler and
was still rather buggy internally.
Revert "Replace
__init__withOncePerProcesson supported Julia versions (#316)"This reverts commit dbcb5d2.
Revert "Make FFTW relocatable for PackageCompiler"
This reverts commit e96270a.
Refs: ccall: make distinction of pointer vs name a syntactic distinction