Skip to content

WIP: Fix Issue #27 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: Fix Issue #27 #28

wants to merge 2 commits into from

Conversation

simonp0420
Copy link
Contributor

@simonp0420 simonp0420 commented Oct 17, 2025 •
edited
Loading

Add methods to bessel_zero_asymptotic and bessel_deriv_zero_asymptotic that promote nu from Integer to float. Fixes Issue #27

@simonp0420
Copy link
Contributor Author

simonp0420 commented Oct 17, 2025 •
edited
Loading

I submitted this PR a little too early. All tests ran successfully on my machine where Int === Int64, but I see some have failed in CI on x86 machines, where Int === Int32, and the @test_broken tests are actually no longer broken. I also now see from the comments preceding the "high nu" test set that Issue #27 is a duplicate of Issue #10. I'll modify this PR to replace the @test_broken tests to @test after which I think everything should work ok.

@simonp0420 simonp0420 changed the title Fix Issue #27 WIP: Fix Issue #27 Oct 17, 2025
@simonp0420
Copy link
Contributor Author

Edit: Changing this to a WIP (Work In Progress) PR since the problem still occurs for even higher nu values. Please don't merge yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@simonp0420