Skip to content

WIP: Fix Issue #27 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: Fix Issue #27 #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
494816f
Fix Issue #27
simonp0420 Oct 17, 2025
4410a5e
Convert @test_broken to @test
simonp0420 Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/FunctionZeros.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ function bessel_zero_asymptotic(nu_in::Real, n::Integer, kind=1)
return zero_asymp
end

bessel_zero_asymptotic(nu::Integer, n::Integer, kind=1) = bessel_zero_asymptotic(float(nu), n, kind) # fix #27

# Use the asymptotic values as starting values.
# These find the correct zeros even for n = 1,2,...
# Order 0 is 6 times slower and 50-100 times less accurate
Expand Down Expand Up @@ -214,6 +216,8 @@ function bessel_deriv_zero_asymptotic(nu_in::Real, n::Integer, kind=1)
return zero_asymp
end

bessel_deriv_zero_asymptotic(nu::Integer, n::Integer, kind=1) = bessel_deriv_zero_asymptotic(float(nu), n, kind) # fix #27

"""
_besselj_deriv_zero(nu, n)

Expand Down
28 changes: 15 additions & 13 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
using FunctionZeros
using FunctionZeros: bessel_zero_asymptotic, bessel_deriv_zero_asymptotic

using Test
using SpecialFunctions: besselj, bessely

Expand Down Expand Up @@ -120,19 +122,9 @@ end
@testset "high nu" begin
@test isapprox(besselj_zero(6, 1), 9.936109524217688)
@test isapprox(besselj_zero(7, 2), 14.821268727013171)

if Int == Int64
@test isapprox(besselj_zero(50, 1), 57.116899160119196)
else
@test_broken isapprox(besselj_zero(50, 1), 57.116899160119196)
end
# FIXME: This gives the incorrect result
# @test_broken isapprox(besselj_zero(60, 1), xxx)
if Int == Int64
@test isapprox(besselj_zero(60, 2), 73.50669452996178)
else
@test_broken isapprox(besselj_zero(60, 2), 73.50669452996178)
end
@test isapprox(besselj_zero(50, 1), 57.116899160119196)
@test isapprox(besselj_zero(60, 1), 73.5066945299618)
@test isapprox(besselj_zero(60, 2), 73.50669452996178)
@test isapprox(bessely_zero(20, 1), 22.625159280072324)
end

Expand Down Expand Up @@ -377,4 +369,14 @@ let nu = min(FunctionZeros.nupre_max, 1)
@test abs(z - zbig) < 5 * eps()
@test abs(bessely(nu-1, zbig) - bessely(nu+1, zbig)) / 2 < 2 * eps(BigFloat)
end

@testset "Issue 27" begin
@test besselj_deriv_zero(37, 1) ≈ besselj_deriv_zero(37.0, 1) ≈ 39.71488992674072
@test bessel_deriv_zero_asymptotic(37, 2, 1) ≈ 47.22868085729076
@test bessel_deriv_zero_asymptotic(BigInt(37), 2, 1) ≈ big"47.22868085729076149030198319523818371811907166937005677029525603864958297422779"
@test bessel_zero_asymptotic(87, 2, 1) ≈ 105.69324719238529
@test bessel_zero_asymptotic(BigInt(87), 2, 1) ≈ big"105.693247192385300157734443161801368795079219923515831608871687185822839565836"
end


end # let
Loading