Skip to content

Add missing bracket in summary of NGMRES and O-ACCEL#1204

Merged
pkofod merged 2 commits intoJuliaNLSolvers:masterfrom
devmotion:dmw/ngmres
Nov 13, 2025
Merged

Add missing bracket in summary of NGMRES and O-ACCEL#1204
pkofod merged 2 commits intoJuliaNLSolvers:masterfrom
devmotion:dmw/ngmres

Conversation

@devmotion
Copy link
Contributor

Currently, the summary of these algorithms is missing or - depending on the initial intention - contains an undesired bracket:

...
    Algorithm:     Nonlinear GMRES preconditioned with Gradient Descent)
...

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

Benchmark Results (Julia vlts)

Time benchmarks
master 8f89253... master / 8f89253...
multivariate/solvers/first_order/AdaMax 0.542 ± 0.0096 ms 0.544 ± 0.0087 ms 0.995 ± 0.024
multivariate/solvers/first_order/Adam 0.541 ± 0.0089 ms 0.544 ± 0.0091 ms 0.994 ± 0.023
multivariate/solvers/first_order/BFGS 0.261 ± 0.0081 ms 0.263 ± 0.0085 ms 0.996 ± 0.045
multivariate/solvers/first_order/ConjugateGradient 0.174 ± 0.003 ms 0.175 ± 0.0029 ms 0.996 ± 0.024
multivariate/solvers/first_order/GradientDescent 1.55 ± 0.012 ms 1.55 ± 0.011 ms 1 ± 0.01
multivariate/solvers/first_order/LBFGS 0.231 ± 0.0068 ms 0.234 ± 0.0083 ms 0.99 ± 0.046
multivariate/solvers/first_order/MomentumGradientDescent 2.17 ± 0.016 ms 2.17 ± 0.013 ms 1 ± 0.0096
multivariate/solvers/first_order/NGMRES 0.429 ± 0.011 ms 0.43 ± 0.012 ms 0.997 ± 0.036
time_to_load 0.41 ± 0.0032 s 0.412 ± 0.006 s 0.994 ± 0.016
Memory benchmarks
master 8f89253... master / 8f89253...
multivariate/solvers/first_order/AdaMax 0.34 k allocs: 7.16 kB 0.34 k allocs: 7.16 kB 1
multivariate/solvers/first_order/Adam 0.34 k allocs: 7.16 kB 0.34 k allocs: 7.16 kB 1
multivariate/solvers/first_order/BFGS 0.336 k allocs: 15 kB 0.336 k allocs: 15 kB 1
multivariate/solvers/first_order/ConjugateGradient 0.332 k allocs: 13.5 kB 0.332 k allocs: 13.5 kB 1
multivariate/solvers/first_order/GradientDescent 1.89 k allocs: 0.0713 MB 1.89 k allocs: 0.0713 MB 1
multivariate/solvers/first_order/LBFGS 0.317 k allocs: 14.2 kB 0.317 k allocs: 14.2 kB 1
multivariate/solvers/first_order/MomentumGradientDescent 2.24 k allocs: 0.077 MB 2.24 k allocs: 0.077 MB 1
multivariate/solvers/first_order/NGMRES 1.51 k allocs: 0.117 MB 1.51 k allocs: 0.117 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

A plot of the benchmark results has been uploaded as an artifact at .

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.56%. Comparing base (b367149) to head (8f89253).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1204   +/-   ##
=======================================
  Coverage   87.56%   87.56%           
=======================================
  Files          45       45           
  Lines        3514     3514           
=======================================
  Hits         3077     3077           
  Misses        437      437           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pkofod
Copy link
Member

pkofod commented Nov 13, 2025

good! benchmarks passed :D

@pkofod pkofod merged commit 3e1393d into JuliaNLSolvers:master Nov 13, 2025
13 checks passed
@devmotion devmotion deleted the dmw/ngmres branch November 13, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants