Skip to content

Commit 2fce4aa

Browse files
committed
@require Neo4j again & moved interfaces.jl to services/AbstractDFG.jl
1 parent f0e1f4d commit 2fce4aa

File tree

3 files changed

+15
-21
lines changed

3 files changed

+15
-21
lines changed

src/DistributedFactorGraphs.jl

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,13 @@ export GenericFunctionNodeData#, FunctionNodeData
3535
export getSerializationModule, setSerializationModule!
3636
export pack, unpack
3737

38+
#Interfaces
39+
export getAdjacencyMatrixSparse
40+
3841
# Common includes
3942
include("services/AbstractDFG.jl")
4043
include("services/DFGVariable.jl")
4144

42-
#TODO @sam I'm just doing it like this at the moment because I don't know a better way.
43-
include("services/interfaces.jl")
44-
export getAdjacencyMatrixSparse
45-
4645
# Include the Graphs.jl API.
4746
include("GraphsDFG/GraphsDFG.jl")
4847

@@ -86,13 +85,10 @@ function __init__()
8685
end
8786
end
8887

89-
#FIXME JT not sure how to handle this
90-
#=
91-
@require Neo4j="d2adbeaf-5838-5367-8a2f-e46d570981db" begin
92-
# Include the Cloudgraphs API
93-
include("CloudGraphsDFG/CloudGraphsDFG.jl")
94-
end
95-
=#
88+
@require Neo4j="d2adbeaf-5838-5367-8a2f-e46d570981db" begin
89+
# Include the Cloudgraphs API
90+
include("CloudGraphsDFG/CloudGraphsDFG.jl")
91+
end
9692

9793
@require GraphPlot = "a2cc645c-3eea-5389-862e-a155d0052231" begin
9894
include("DFGPlots/DFGPlots.jl")
@@ -101,8 +97,6 @@ function __init__()
10197

10298
end
10399

104-
#FIXME JT not sure how to handle this, is it not lightweitgh enought to always include?
105-
include("CloudGraphsDFG/CloudGraphsDFG.jl")
106100

107101
# not sure where to put
108102
include("Common.jl")

src/services/AbstractDFG.jl

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,3 +74,11 @@ end
7474
function _getname(t::T) where T
7575
T.name.name
7676
end
77+
78+
## Interfaces
79+
"""
80+
$(SIGNATURES)
81+
Get an adjacency matrix for the DFG, returned as a tuple: adjmat::SparseMatrixCSC{Int}, var_labels::Vector{Symbol) fac_labels::Vector{Symbol).
82+
Rows are the factors, columns are the variables, with the corresponding labels in fac_labels,var_labels.
83+
"""
84+
getAdjacencyMatrixSparse(dfg::AbstractDFG) = error("getAdjacencyMatrixSparse not implemented for $(typeof(dfg))")

src/services/interfaces.jl

Lines changed: 0 additions & 8 deletions
This file was deleted.

0 commit comments

Comments
 (0)