Closed
Conversation
The use of CPUInfo makes `--trim` difficult. Removing this dependency here would unlock a large amount of libraries which use the Polyester library to be trimmmable (notably e.g. almost everything in the SciML ecosystem). However, we might need a bit more discussion on the exact removal of this feature.
Member
|
@oscardssmith can you follow up to check whether these cause any performance regression? I would assume not. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
- Coverage 43.75% 0.00% -43.75%
==========================================
Files 4 4
Lines 128 126 -2
==========================================
- Hits 56 0 -56
- Misses 72 126 +54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ChrisRackauckas
pushed a commit
to ChrisRackauckas/PolyesterWeave.jl
that referenced
this pull request
Jul 29, 2025
This commit fixes a critical bug that occurs when using more than 64 threads.
The change from CPUSummary.sys_threads() to Threads.nthreads() introduced
a type instability where worker_bits() and worker_mask_count() would return
regular Int instead of StaticInt types with high thread counts.
Changes:
- Modified worker_bits() to always return Int for consistency
- Updated worker_mask_count() to use regular integer division
- Added new _request_threads method that handles Int parameter
- Added test for high thread count compatibility
The fix maintains backward compatibility while ensuring the code works
correctly with any number of threads.
Fixes the MethodError: no method matching _request_threads(::UInt32, ::Ptr{UInt64}, ::Int64, ::Nothing)
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
|
|
||
| function worker_bits() | ||
| wts = nextpow2(CPUSummary.sys_threads()) # Typically sys_threads (i.e. Sys.CPU_THREADS) does not change between runs, thus it will precompile well. | ||
| wts = nextpow2(Threads.nthreads()) # Typically sys_threads (i.e. Sys.CPU_THREADS) does not change between runs, thus it will precompile well. |
Member
There was a problem hiding this comment.
Suggested change
| wts = nextpow2(Threads.nthreads()) # Typically sys_threads (i.e. Sys.CPU_THREADS) does not change between runs, thus it will precompile well. | |
| wts = nextpow2(StaticInt{Threads.nthreads()}()) # Typically sys_threads (i.e. Sys.CPU_THREADS) does not change between runs, thus it will precompile well. |
Member
|
Should no longer be required due to JuliaSIMD/CPUSummary.jl#31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of CPUInfo makes
--trimdifficult.Removing this dependency here would unlock a large amount of libraries which use the Polyester library to be trimmmable (notably e.g. almost everything in the SciML ecosystem).
However, we might need a bit more discussion on the exact removal of this feature.