Bump JSOSolvers to 0.14 and in JSOSolvers tutorials #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eyword API (fixes JuliaSmoothOptimizers#145) - Add migration note showing old subsolver_type => new subsolver=:symbol API - Update solver dictionary examples to use subsolver = :cgls, :crls, :lsqr, :lsmr - Add explicit TRUNK and TRON examples with subsolver, rtol, atol, max_time - Add reference to JSOSolvers allowed_subsolvers lists - Link to Krylov.jl docs for subsolver algorithm details - Fix grammar and copy edits (heading, wording, plurals)
|
@tmigot please review. |
arnavk23
changed the title
|
@tmigot please see the checks below. |
… for complete JuliaSmoothOptimizers#145 fix - Add migration note at top explaining subsolver_type => subsolver API change - Link to Krylov.jl documentation for subsolver algorithm details - Ensures users understand the new API and can find detailed subsolver info
- Filter out non-directory items (like files in scripts/) - Only check for index.jmd and Project.toml (not generated files) - Fixes test suite that was failing on both main and fix branches
|
@tmigot worked on the failing test of the previous pr. |
tmigot
requested changes
Oct 21, 2025
Co-authored-by: Tangi Migot <[email protected]>
The previous changes attempted to use `subsolver = :symbol` API which doesn't exist in JSOSolvers 0.11. Testing confirmed that JSOSolvers 0.11 uses `subsolver_type = Type` (e.g., CglsSolver, LsmrSolver). This commit reverts to the correct working API that is compatible with JSOSolvers 0.11.2.
tmigot
reviewed
Oct 21, 2025
- Update JSOSolvers from 0.11 to 0.14 in Project.toml files - Update Krylov from 0.9 to 0.10 (required by JSOSolvers 0.14) - Replace Type-based subsolver API with Symbol-based API: * subsolver_type = CglsSolver → subsolver = :cgls * subsolver_type = LsmrSolver → subsolver = :lsmr * etc. - Remove Krylov.jl import (no longer needed for subsolver types) - Remove compatibility note about JSOSolvers 0.11 This addresses issue JuliaSmoothOptimizers#145 by updating to the new subsolver API introduced in JSOSolvers 0.14.0. Affected tutorials: - tutorials/advanced-jsosolvers/ - tutorials/introduction-to-jsosolvers/ Tests: All package tests pass ✓
arnavk23
force-pushed
the
fix/advanced-jsosolvers-subsolver-api
branch
from
d00a69b to
e8cb911
Compare
The version badge on the site is derived from the local Project.toml, so we test against tutorials/introduction-to-jsosolvers/Project.toml. This change guarantees the constants are referenced after importing JSOSolvers (v0.14+ Symbol subsolver API).
tmigot
reviewed
Oct 21, 2025
tmigot
reviewed
Oct 21, 2025
tmigot
changed the title
Removed unnecessary code block delimiters from documentation.
Updated import statements to include ADNLPModels with JSOSolvers.
tmigot
approved these changes
Oct 23, 2025
tmigot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fixes #145)
New tutorial
Updates to tutorial