Skip to content

Conversation

@wsmoses
Copy link
Contributor

@wsmoses wsmoses commented Jan 9, 2025

It looks like in base that error was only enabled on number inputs, lets see if this fixes it?

cc @gbaraldi @KristofferC

@wsmoses
Copy link
Contributor Author

wsmoses commented Jan 9, 2025

okay @dkarrasch would you mind merging this? According to @gbaraldi on a local test this fixed the issue in JuliaLang/julia#56653 (comment) blocking the 1.10.8 release

@dkarrasch dkarrasch merged commit 248d9f9 into JuliaSparse:release-1.10 Jan 9, 2025
7 checks passed
@wsmoses wsmoses deleted the errty branch January 9, 2025 20:38
@codecov
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.64%. Comparing base (78035e1) to head (2e13389).
Report is 1 commits behind head on release-1.10.

Files with missing lines Patch % Lines
src/sparsevector.jl 66.66% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.10     #592   +/-   ##
=============================================
  Coverage         92.64%   92.64%           
=============================================
  Files                12       12           
  Lines              7677     7678    +1     
=============================================
+ Hits               7112     7113    +1     
  Misses              565      565           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants