Skip to content

More adhereance to 1.10 error types (hopefully) #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 9, 2025
Merged

More adhereance to 1.10 error types (hopefully) #592

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83e18eb
More adhereance to 1.10 error types (hopefully)
wsmoses Jan 9, 2025
1b990c1
Update src/sparsevector.jl
wsmoses Jan 9, 2025
2e13389
Update sparsevector.jl
wsmoses Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions src/sparsevector.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1243,15 +1243,17 @@ function hvcat_internal(rows::Tuple{Vararg{Int}}, X1::_SparseConcatGroup, X::_Sp
if anysparse(X1) || anysparse(X...)
vcat(_hvcat_rows(rows, X1, X...)...)
else
# Needed to match error type with Base Julia. See https://github.com/JuliaLang/julia/pull/56543#issuecomment-2508637550
matrix_len = if length(rows) == 0
0
else
length(rows) * rows[1]
end
if matrix_len != 1 + length(X)
throw(ArgumentError("argument count does not match specified shape (expected $matrix_len, got $(1+length(X)))"))
end
if X1 <: Number && all(Base.Fix1(<:, Number), X)
# Needed to match error type with Base Julia. See https://github.com/JuliaLang/julia/pull/56543#issuecomment-2508637550
matrix_len = if length(rows) == 0
0
else
length(rows) * rows[1]
end
if matrix_len != 1 + length(X)
throw(ArgumentError("argument count does not match specified shape (expected $matrix_len, got $(1+length(X)))"))
end
end
Base.typed_hvcat(Base.promote_eltypeof(X1, X...), rows, X1, X...)
end
end
Expand Down
Loading