Add --fail-fast option to CLI #118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a `--fail-fast` flag to the CLI that can be used to exit early instead of running remaining checks. The default behavior have changed from failing fast to running all checks.
ericphanson
reviewed
Jun 19, 2025
There was a problem hiding this comment.
It could use a test case in https://github.com/JuliaTesting/ExplicitImports.jl/blob/main/test/main.jl, otherwise lgtm
|
Hmm, looks like without --fail-fast you still miss some diagnostics because the various passes bail early, e.g. ExplicitImports.jl/src/checks.jl Line 166 in f98b7dd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a
--fail-fastflag to the CLI that can be used to exit early instead of running remaining checks. The default behavior have changed from failing fast to running all checks.