Skip to content

Add --fail-fast option to CLI #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add --fail-fast option to CLI #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/main.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,16 +99,23 @@ function activate_and_load(package, project_path)
end
end

function run_checks(package, selected_checks)
function run_checks(package, selected_checks; fail_fast::Bool = false)
errs = []
for check in selected_checks
@info "Checking $check"
try
@eval Main $ExplicitImports.$(Symbol("check_" * check))($package)
catch e
push!(errs, e)
fail_fast && break
end
end
if !isempty(errs)
for err in errs
printstyled(stderr, "ERROR: "; bold=true, color=:red)
Base.showerror(stderr, e)
return 1
Base.showerror(stderr, err)
end
return 1
end
return 0
end
Expand All @@ -132,6 +139,8 @@ function print_help()
println(io, " Path to the root directory of the package (default: pwd)")
println(io, " --help")
println(io, " Show this message")
println(io, " --fail-fast")
println(io, " Exit on first --check error and skip remaining ones")
println(io, " --check")
println(io,
" Run checks instead of printing. If --checklist is not specified, all checks are run")
Expand Down Expand Up @@ -161,6 +170,7 @@ function main(args)
selected_checks = copy(CHECKS)
should_run_checks = false
should_print = false
fail_fast = false
path = "."

# Argument parsing
Expand All @@ -172,6 +182,8 @@ function main(args)
return 0
elseif x == "--check"
should_run_checks = true
elseif x == "--fail-fast"
fail_fast = true
elseif x == "--print"
should_print = true
elseif x == "--checklist"
Expand Down Expand Up @@ -241,7 +253,7 @@ function main(args)
if length(selected_checks) == 0
return err("The passed combination of checks $values made the selection empty.")
end
return run_checks(package, selected_checks)
return run_checks(package, selected_checks; fail_fast)
end
return 0
end
Expand Down
Loading