Fix error handling tests for Julia 1.12#493
Open
jariji wants to merge 2 commits intoJunoLab:masterfrom
Open
Conversation
Julia 1.12 added source locations to ParseError messages and module names to UndefVarError messages. These differ between the test's include_string(Main, ...) and Weave's execution context (temp files, sandbox module). Normalize these context-dependent parts before comparing error strings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Test Julia lts, 1 (stable), and pre (allow-failure) - Drop x86 and Julia 1.5 - Add julia-actions/cache@v3 - Update checkout@v6, setup-julia@v2, codecov@v5 - Add concurrency groups to cancel redundant runs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 74.01% 74.43% +0.42%
==========================================
Files 26 26
Lines 1351 1428 +77
==========================================
+ Hits 1000 1063 +63
- Misses 351 365 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Would be good to explicitly test on 1.12 and Windows too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParseErrormessages include source locations andUndefVarErrormessages include module namesinclude_string(Main, ...)and Weave's execution context (temp files, sandbox module), causing 3 test failuresTest plan
Pkg.test()passes: 194 passed, 2 broken (pre-existing), 0 failed🤖 Generated with Claude Code