Made small text adjustments to loc /splash and /issues #1722
Conversation
|
|
||
| assert second.area_complained_of_mc == hp.AreaComplainedOfMC.PUBLIC_AREA | ||
| assert second.which_room_mc.value == "Public areas" # type: ignore | ||
| assert second.which_room_mc.value == "Building-wide" # type: ignore |
There was a problem hiding this comment.
Hey @toolness! Noticed that me changing the names of the issue areas broke this HPA back-end test. I fixed it here but just wanted to make sure there weren't any other HP-related consequences of this copy change. Lmk!
There was a problem hiding this comment.
Ah right, there shouldn't be any, since outside of tests, all string comparisons are done against the "code" (e.g. `PUBLIC_AREAS") rather than the user-facing string! NOICE
|
@toolness on the second thought, lemme just get your eyes on this quick— see my comment above ^^ |
| HOME: "Home-wide", | ||
| PUBLIC_AREAS: "Building-wide", |
There was a problem hiding this comment.
One of the requests was to reorder these sections, hence the change here
toolness
left a comment
toolness
left a comment
There was a problem hiding this comment.
This looks good to me! Just to confirm, all the changes you made don't need to be internationalized or translated prior to pushing to production right?
|
|
||
| assert second.area_complained_of_mc == hp.AreaComplainedOfMC.PUBLIC_AREA | ||
| assert second.which_room_mc.value == "Public areas" # type: ignore | ||
| assert second.which_room_mc.value == "Building-wide" # type: ignore |
There was a problem hiding this comment.
Ah right, there shouldn't be any, since outside of tests, all string comparisons are done against the "code" (e.g. `PUBLIC_AREAS") rather than the user-facing string! NOICE
|
@toolness yep! They're only LOC (and bc of the issues, EHP) changes, and since those tools aren't i18n enabled yet, we can push this. |
#1722 made some trivial re-orderings to how we list issue areas, but due to Django's migration logic sillyness (which I think has actually just been fixed in Django's main branch) it requires a completely trivial migration. This is it.
This PR makes some minor tweaks to our Letter of Complaint content, as requested during a content audit.