Skip to content

Made small text adjustments to loc /splash and /issues #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sraby merged 5 commits into from
Oct 19, 2020
Merged

Made small text adjustments to loc /splash and /issues #1722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b2b611
Made small text adjustments to loc /splash and /issues
sraby Oct 19, 2020
0208156
reran commondata command
sraby Oct 19, 2020
0eeaff7
update snapshot
sraby Oct 19, 2020
25109d8
fixed hpa test using issue area names
sraby Oct 19, 2020
bbe8931
Update schema.json
sraby Oct 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common-data/issue-area-choices.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
[
["HOME", "Entire home and hallways"],
["BEDROOMS", "Bedrooms"],
["KITCHEN", "Kitchen"],
["LIVING_ROOM", "Living room"],
["BATHROOMS", "Bathrooms"],
["PUBLIC_AREAS", "Public areas"],
["HOME", "Home-wide"],
["PUBLIC_AREAS", "Building-wide"],
["LANDLORD", "Landlord harassment (currently hidden in app)"]
]
8 changes: 4 additions & 4 deletions common-data/issue-area-choices.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
// This file was auto-generated by commondatabuilder.
// Please don't edit it.

export type IssueAreaChoice = "HOME"|"BEDROOMS"|"KITCHEN"|"LIVING_ROOM"|"BATHROOMS"|"PUBLIC_AREAS";
export type IssueAreaChoice = "BEDROOMS"|"KITCHEN"|"LIVING_ROOM"|"BATHROOMS"|"HOME"|"PUBLIC_AREAS";

export const IssueAreaChoices: IssueAreaChoice[] = [
"HOME",
"BEDROOMS",
"KITCHEN",
"LIVING_ROOM",
"BATHROOMS",
"HOME",
"PUBLIC_AREAS"
];

Expand All @@ -24,11 +24,11 @@ export type IssueAreaChoiceLabels = {

export function getIssueAreaChoiceLabels(): IssueAreaChoiceLabels {
return {
HOME: "Entire home and hallways",
BEDROOMS: "Bedrooms",
KITCHEN: "Kitchen",
LIVING_ROOM: "Living room",
BATHROOMS: "Bathrooms",
PUBLIC_AREAS: "Public areas",
HOME: "Home-wide",
PUBLIC_AREAS: "Building-wide",
Comment on lines +31 to +32
Copy link
Member Author

@sraby sraby Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the requests was to reorder these sections, hence the change here

};
}
4 changes: 2 additions & 2 deletions frontend/lib/loc/letter-of-complaint-splash.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export function LocSplash(): JSX.Element {
/>
</div>
<h1 className="title is-spaced">
Is your landlord not responding? Take action today!
Need Repairs in Your Apartment? Take action today!
</h1>
<p className="subtitle">
This is a free tool that notifies your landlord of repair issues
Expand Down Expand Up @@ -69,7 +69,7 @@ export function LocSplash(): JSX.Element {
<BigList itemClassName="title is-5">
<li>
Customize our lawyer-approved letter template to choose the
repairs you need in your home.
repairs you need in your home and/or building.
</li>
<li>
We mail your letter via USPS Certified Mail
Expand Down
2 changes: 1 addition & 1 deletion frontend/lib/loc/tests/__snapshots__/letter-content.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ exports[`<LocContent> works 1`] = `
Repairs required
</h2>
<h3>
Entire home and hallways
Home-wide
</h3>
<ul>
<li>
Expand Down
2 changes: 1 addition & 1 deletion hpaction/tests/test_build_hpactionvars.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def test_user_to_hpactionvars_populates_issues(db):
assert first.conditions_complained_of_te == "Mold on walls"

assert second.area_complained_of_mc == hp.AreaComplainedOfMC.PUBLIC_AREA
assert second.which_room_mc.value == "Public areas" # type: ignore
assert second.which_room_mc.value == "Building-wide" # type: ignore
Copy link
Member Author

@sraby sraby Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @toolness! Noticed that me changing the names of the issue areas broke this HPA back-end test. I fixed it here but just wanted to make sure there weren't any other HP-related consequences of this copy change. Lmk!

Copy link
Collaborator

@toolness toolness Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, there shouldn't be any, since outside of tests, all string comparisons are done against the "code" (e.g. `PUBLIC_AREAS") rather than the user-facing string! NOICE

assert second.conditions_complained_of_te == "lobby is consumed by darkness"
v.to_answer_set()

Expand Down
14 changes: 7 additions & 7 deletions schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3781,12 +3781,6 @@
{
"description": "An enumeration.",
"enumValues": [
{
"deprecationReason": null,
"description": "Entire home and hallways",
"isDeprecated": false,
"name": "HOME"
},
{
"deprecationReason": null,
"description": "Bedrooms",
Expand All @@ -3813,7 +3807,13 @@
},
{
"deprecationReason": null,
"description": "Public areas",
"description": "Home-wide",
"isDeprecated": false,
"name": "HOME"
},
{
"deprecationReason": null,
"description": "Building-wide",
"isDeprecated": false,
"name": "PUBLIC_AREAS"
},
Expand Down