MacOS: Add support for timers to the platform integrations#10
Closed
MacOS: Add support for timers to the platform integrations#10
Conversation
zakalawe
reviewed
Jun 13, 2024
milianw
reviewed
Jun 18, 2024
milianw
left a comment
milianw
left a comment
There was a problem hiding this comment.
just some minor nits that I saw while looking at the code
iamsergio
added a commit
that referenced
this pull request
Jan 15, 2025
Done by Abhishek in PR #10 but had gmail address. Task-Id: SRNTY-40
Merged
Contributor
|
Move to PR #49 since I don't have access to the author's branch to amend stuff |
iamsergio
added a commit
that referenced
this pull request
Jan 15, 2025
Done by Abhishek in PR #10 but had gmail address. Task-Id: SRNTY-40
iamsergio
added a commit
that referenced
this pull request
Jan 15, 2025
Done by Abhishek in PR #10 but had gmail address. Task-Id: SRNTY-40
seanharmer
pushed a commit
that referenced
this pull request
Jan 22, 2025
* Add support for macOS timers Done by Abhishek in PR #10 but had gmail address. Task-Id: SRNTY-40 * minor fixes for Abhishek's patch - fixed include order (local before system) - fixed unused variable - made member pointer const so reader knows it always gets initialized - nullptr instead of NULL as nagged by clang-tidy * ci: Fix macOS timeouts These tests pass locally but consistently timeout when run under GH CI. Increased the timeouts only for macOS GH runners. Running tests locally should still be done without hacks. * cmake: Enable CMAKE_EXPORT_COMPILE_COMMANDS in the preset Allows to use vscode for hacking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for MacOS timers using libdispatch
Task-Id:SRNTY-40