Merged
Conversation
iamsergio
force-pushed
the
macos-timers
branch
from
d1f66b6 to
e9447a0
Compare
Done by Abhishek in PR #10 but had gmail address. Task-Id: SRNTY-40
- fixed include order (local before system) - fixed unused variable - made member pointer const so reader knows it always gets initialized - nullptr instead of NULL as nagged by clang-tidy
iamsergio
force-pushed
the
macos-timers
branch
from
e9447a0 to
377382e
Compare
iamsergio
force-pushed
the
macos-timers
branch
4 times, most recently
from
0dcf456 to
1076acf
Compare
These tests pass locally but consistently timeout when run under GH CI. Increased the timeouts only for macOS GH runners. Running tests locally should still be done without hacks.
Allows to use vscode for hacking.
iamsergio
force-pushed
the
macos-timers
branch
from
7e2062a to
99444ca
Compare
seanharmer
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements timer support for macOS platform.
Replaces PR #10 since I don't have access to the author's branch to amend stuff.