style: use semantic focus-ring token across components#2168
style: use semantic focus-ring token across components#2168pixelflips merged 2 commits intodevelopfrom
Conversation
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThe pull request updates focus ring color tokens across multiple SCSS component files in the sage-assets package. Focus outline colors are changed from 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Stylelint (17.3.0)packages/sage-assets/lib/stylesheets/components/_breadcrumbs.scssConfigurationError: Could not find "stylelint-config-sass-guidelines". Do you need to install the package or use the "configBasedir" option? packages/sage-assets/lib/stylesheets/components/_button.scssConfigurationError: Could not find "stylelint-config-sass-guidelines". Do you need to install the package or use the "configBasedir" option? packages/sage-assets/lib/stylesheets/components/_choice.scssConfigurationError: Could not find "stylelint-config-sass-guidelines". Do you need to install the package or use the "configBasedir" option?
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
* chore(deps): bump @pine-ds/icons from 9.16.0 to 9.17.0 (#2166) Bumps [@pine-ds/icons](https://github.com/Kajabi/pine-icons) from 9.16.0 to 9.17.0. - [Release notes](https://github.com/Kajabi/pine-icons/releases) - [Changelog](https://github.com/Kajabi/pine-icons/blob/main/CHANGELOG.md) - [Commits](Kajabi/pine-icons@v9.16.0...v9.17.0) --- updated-dependencies: - dependency-name: "@pine-ds/icons" dependency-version: 9.17.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * style: use semantic focus-ring token across components (#2168) * style: replace hardcoded purple-600 with focus-ring token * style(breadcrumbs): add focus ring to progressbar variant * feat(hero): add shadow prop (#2170) * feat(hero): add shadow prop to React component and SCSS * feat(hero): add shadow prop to Rails component * docs(hero): add shadow prop documentation and preview examples * fix(hero): quote 050 shadow key in SCSS map and fix alt text hyphenation * fix(avatar): use semantic token (#2171) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Quinton Jason <quinton.jason@gmail.com>
Summary
var(--pine-color-purple-600)withvar(--pine-color-focus-ring)in 10 component stylesheetsFixes DSS-91
Components Updated
button, choice, link, dropdown, pagination, breadcrumbs, nav, alert, status_icon, media_tile, hero
Test plan
:focus-visiblering renders correctlypurple-600in focus-ring contexts