Conversation
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughAdds a new 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Stylelint (17.3.0)packages/sage-assets/lib/stylesheets/components/_hero.scssConfigurationError: Could not find "stylelint-config-sass-guidelines". Do you need to install the package or use the "configBasedir" option? Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/sage-assets/lib/stylesheets/components/_hero.scss`:
- Around line 69-86: The map key 050 is treated as a numeric 50 and loses its
leading zero during interpolation, so update the $-sage-hero-shadows map to use
a quoted string key ("050") and pass the shadow token as a quoted argument to
sage-shadow (e.g., sage-shadow("050")) so that .sage-hero--shadow-#{$-key}
generates .sage-hero--shadow-050 and matches the value used in configs.js;
adjust only the key and the corresponding sage-shadow call in the
$-sage-hero-shadows map.
In `@packages/sage-react/lib/Hero/Hero.story.mdx`:
- Around line 141-157: The alt text for the Hero story uses "Multi layered" but
should be hyphenated as a compound adjective; update the image prop in the
"Shadow" Story for the Hero component (the image.alt value passed to <Hero ...
image={{ src: heroFull, alt: 'Multi layered illustration...' }}>) to
"Multi-layered illustration of UI elements and woman clasping her hands together
in excitement".
|
@coderabbitai i have addressed the reported issues, please review |
|
✅ Actions performedReview triggered.
|
* chore(deps): bump @pine-ds/icons from 9.16.0 to 9.17.0 (#2166) Bumps [@pine-ds/icons](https://github.com/Kajabi/pine-icons) from 9.16.0 to 9.17.0. - [Release notes](https://github.com/Kajabi/pine-icons/releases) - [Changelog](https://github.com/Kajabi/pine-icons/blob/main/CHANGELOG.md) - [Commits](Kajabi/pine-icons@v9.16.0...v9.17.0) --- updated-dependencies: - dependency-name: "@pine-ds/icons" dependency-version: 9.17.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * style: use semantic focus-ring token across components (#2168) * style: replace hardcoded purple-600 with focus-ring token * style(breadcrumbs): add focus ring to progressbar variant * feat(hero): add shadow prop (#2170) * feat(hero): add shadow prop to React component and SCSS * feat(hero): add shadow prop to Rails component * docs(hero): add shadow prop documentation and preview examples * fix(hero): quote 050 shadow key in SCSS map and fix alt text hyphenation * fix(avatar): use semantic token (#2171) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Quinton Jason <quinton.jason@gmail.com>
Summary
Fixes DSS-169
shadowprop to the Sage Hero component (React and Rails) that applies abox-shadowto the Hero containernone,050,100,150,200,300,400,500) are aligned with Pine'spds-boxshadow scale for cross-system consistencysage-hero--shadow-{value}nil/null— no shadow class is added when the prop is omitted, preserving current behaviorChanges
Implementation
_hero.scss— shadow modifier classes via@eachloop over$-sage-hero-shadowsmapconfigs.js—HERO_SHADOWSconstantHero.jsx—shadowprop with classnames integration, static ref, default, and propTypesage_tokens.rb—HERO_SHADOWStoken arraysage_schemas.rb—HERO_SHADOWschema setsage_hero.rb—shadowattribute in schema_sage_hero.html.erb— conditional shadow class outputDocumentation
_props.html.erb— shadow prop added to Properties tab_preview.html.erb— shadow example added to Preview tabHero.story.mdx— shadow story added to StorybookTest plan
.sage-hero--shadow-*classes are generated with correctbox-shadowvaluesshadowprop appears in controls and the Shadow story renders correctlysage-hero--shadow-100class appears on the<article>element