Skip to content

Conversation

@hendrikmuhs
Copy link
Contributor

@hendrikmuhs hendrikmuhs commented Nov 3, 2024

Fixes builds using the latest cibuildwheel. Due to incompatible changes introduced upstream pypy(pypa/distutils#283) had to be taken out for now.

In the long run we should switch away from setuptools, so these changes are just considered temporary until #310 is ready.

dependabot bot and others added 7 commits November 3, 2024 18:29
@hendrikmuhs hendrikmuhs changed the title Try to fix the build Adapt build to new cibuildwheel and other upstream changes Nov 4, 2024
@hendrikmuhs hendrikmuhs marked this pull request as ready for review November 4, 2024 07:15
@hendrikmuhs hendrikmuhs merged commit 1223704 into KeyviDev:master Nov 6, 2024
hendrikmuhs added a commit that referenced this pull request Aug 7, 2025
after updating boost in #314, this PR fixes some issues:

    - newer versions of boost require linking the process library, see 

Compiling Boost.Process as header-only fails  boostorg/process#390

    - older versions don't ship boost process and the upcoming 1.89 might go back to header-only

- fix linking on macos for newer boost and remove pinning 1.85

    - reason: upstream brew package removed boost_thread-mt, now there is only boost_thread (-mt is now default), same as on Linux
    - Mac users that compile from source need to update boost

- fix cmake deprecation warning

    - only applies to very old boost versions which aren't supported anyway, raised the minimum required versions to 1.80 for boost process v2
    - update ubuntu version for rust workflow to get newer boost there
        - rust bindings don't support keyvi index, that's why the newer boost wasn't necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant