-
Notifications
You must be signed in to change notification settings - Fork 357
Update dropdown labeling guidance to internal article #2504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Size Change: +20 B (0%) Total Size: 471 kB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (8503d21) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2504 If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -s y -t PR2504 |
target="_blank" | ||
rel="noreferrer" | ||
> | ||
this article. | ||
this internal article. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My one question is: can we link to an internal article in this project? Or am I not adequately considering external audiences since this is an OS project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally think it would be preferable to avoid linking to internal links from the UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the response! How do we give relevant advice to authors, in that case? Publish something external?
Summary:
I got feedback from the Content team that the w3c-WAI article linked from the editor was too technical for the audience. So I created an internal doc that we can maintain, that also links to the previous article for those who are curious.
Issue: FEI-6288
Test plan: