Skip to content

Update dropdown labeling guidance to internal article #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update dropdown labeling guidance to internal article #2504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4943e63
[FEI-6288] Update label guidance to internal article
marcysutton May 19, 2025
8503d21
[FEI-6288] docs(changeset): Update dropdown labeling doc to internal …
marcysutton May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wild-poets-press.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@khanacademy/perseus-editor": patch
---

Update dropdown labeling doc to internal article
4 changes: 2 additions & 2 deletions packages/perseus-editor/src/widgets/dropdown-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,11 +147,11 @@ class DropdownEditor extends React.Component<Props> {
exercise is accessible. For more information on
writing accessible labels, please see{" "}
<a
href="https://www.w3.org/WAI/tips/designing/#ensure-that-form-elements-include-clearly-associated-labels"
href="https://khanacademy.atlassian.net/wiki/spaces/A11Y/pages/3967615350/General+Guidance+for+Labeling+Dropdowns"
target="_blank"
rel="noreferrer"
>
this article.
this internal article.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My one question is: can we link to an internal article in this project? Or am I not adequately considering external audiences since this is an OS project?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally think it would be preferable to avoid linking to internal links from the UI.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the response! How do we give relevant advice to authors, in that case? Publish something external?

</a>{" "}
If left blank, the value will default to
&quot;Select an answer&quot;.
Expand Down
4 changes: 2 additions & 2 deletions packages/perseus-editor/src/widgets/expression-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,11 +388,11 @@ class ExpressionEditor extends React.Component<Props, State> {
For more information on writting accessible
labels, please see{" "}
<a
href="https://www.w3.org/WAI/tips/designing/#ensure-that-form-elements-include-clearly-associated-labels"
href="https://khanacademy.atlassian.net/wiki/spaces/A11Y/pages/3967615350/General+Guidance+for+Labeling+Dropdowns"
target="_blank"
rel="noreferrer"
>
this article.
this internal article.
</a>
</InfoTip>
</>
Expand Down
Loading