Delete TODOs we're never going to fix#3197
Conversation
🗄️ Schema Change: No Changes ✅ |
🛠️ Item Splitting: No Changes ✅ |
|
Size Change: 0 B Total Size: 485 kB ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (8dc0a8d) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3197If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3197If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3197 |
benchristel
force-pushed
the
benc/delete-old-todos
branch
from
cfcd6de to
2d6edf0
Compare
| /** | ||
| * @deprecated - do not use in new code. | ||
| */ | ||
| getSerializedState(): State; |
There was a problem hiding this comment.
getSerializedState is deprecated; hence, we're never going to type this.
| showWordCount={true} | ||
| warnNoPrompt={false} | ||
| warnNoWidgets={true} | ||
| // TODO(LEMS-2656): remove TS suppression |
There was a problem hiding this comment.
There is no TS suppression here.
| // TODO(eater): The 22nd function added will be {(x) since '{' | ||
| // comes after 'z' |
There was a problem hiding this comment.
This is a funny bug, but the interaction widget is very dead, so we are never going to fix it.
| /** | ||
| * An answer item in the choices list. | ||
| * | ||
| * TODO(michaelpolyak): Implement answer reordering, CP-117 |
There was a problem hiding this comment.
CP-117 has been marked Won't Do.
There was a problem hiding this comment.
Also, I think our label-image widget editor supports re-ordering by dragging.
| // it can be triggered from within the widget, or requires | ||
| // a similar implementation locally, in which case consider | ||
| // refactoring `perseus-admin-package/image-upload-dialog.jsx` | ||
| // as common utility, CP-118 |
There was a problem hiding this comment.
CP-118 has been marked Won't Do.
There was a problem hiding this comment.
Molecule is a dead widget.
| // TODO(kevinb) actually compute the size of the graphie correctly and | ||
| // make it that size so we don't have to add extra padding. The value | ||
| // was determined by eye-balling the layout. :( | ||
| const paddingForBottomLabel = 75; |
There was a problem hiding this comment.
This is a gross hack, but plotter is deprecated and hidden from the widget dropdown in the editors, so it's probably not worth fixing.
| // be independent of everything else. | ||
| import type {KeypadKey} from "./keypad"; | ||
|
|
||
| // TODO(FEI-4010): Remove `Perseus` prefix for all types here |
There was a problem hiding this comment.
commentary Hm. This ticket was closed as Won't Do, but I think it's still a valuable thing. React doesn't prefix its symbols with ReactXyz (typically) and we could shorten alot of our types by removing the prefix. That said, probably a very low-value set of work.
TLDR: I'm good with removing this TODO. :)
| {value: "", content: <span>—</span>}, | ||
| {value: "->", content: <span>→</span>}, | ||
| /* | ||
| TODO(eater): fix khan-exercises so these are supported |
There was a problem hiding this comment.
khan-exercises?? 😂 That's a while ago
| /** | ||
| * An answer item in the choices list. | ||
| * | ||
| * TODO(michaelpolyak): Implement answer reordering, CP-117 |
There was a problem hiding this comment.
Also, I think our label-image widget editor supports re-ordering by dragging.
|
|
||
| /* TODO(benkomalo): ughhh. kill or move this out of here :( | ||
| Styles specifically for the mobile native apps */ | ||
| /* Styles specifically for the mobile native apps */ |
There was a problem hiding this comment.
I wonder ... if this is used now that mobile uses the web experience. 🤔 No change necessary on this PR, but can this be removed entirelY?
benchristel
changed the title
benchristel
changed the title
2 participants
Some of these TODOs represent the wishful thinking of our forebears a decade
ago. Others have become obsolete as code changed around them. I'd like to be
able to grep for TODO in our codebase and get a sense of where the real tech
debt is, and having old, won't-fix TODOs makes that difficult.
If any of the removed TODOs are truly important, I trust they'll come back.
Issue: none
Test plan:
none