Skip to content

Add missing call to vkCmdSetRenderingInputAttachmentIndicesKHR in sample dynamic_rendering_local_read #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marty-johnson59 merged 1 commit into from
Nov 3, 2025
Merged

Add missing call to vkCmdSetRenderingInputAttachmentIndicesKHR in sample dynamic_rendering_local_read #1424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions samples/extensions/dynamic_rendering_local_read/dynamic_rendering_local_read.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,15 +686,7 @@ void DynamicRenderingLocalRead::prepare_pipelines()
pipeline_rendering_create_info.stencilAttachmentFormat = depth_format;
}

VkRenderingInputAttachmentIndexInfo rendering_attachment_index_info{VK_STRUCTURE_TYPE_RENDERING_INPUT_ATTACHMENT_INDEX_INFO};
pipeline_rendering_create_info.pNext = &rendering_attachment_index_info;

std::array<uint32_t, 4> colorAttachments = {VK_ATTACHMENT_UNUSED, 0, 1, 2};
rendering_attachment_index_info.pNext = nullptr;
rendering_attachment_index_info.colorAttachmentCount = colorAttachments.size();
rendering_attachment_index_info.pColorAttachmentInputIndices = colorAttachments.data();
rendering_attachment_index_info.pDepthInputAttachmentIndex = nullptr;
rendering_attachment_index_info.pStencilInputAttachmentIndex = nullptr;
#else
pipeline_create_info.subpass = 0;
#endif
Expand Down Expand Up @@ -902,6 +894,9 @@ void DynamicRenderingLocalRead::build_command_buffers()
VkRect2D scissor = vkb::initializers::rect2D(width, height, 0, 0);
vkCmdSetScissor(cmd, 0, 1, &scissor);

// Set input attachment indices for the composition and transparent passes
vkCmdSetRenderingInputAttachmentIndicesKHR(cmd, &rendering_attachment_index_info);

/*
First draw
Fills the G-Buffer attachments containing image data for the deferred composition (color+depth, normals, albedo)
Expand Down
6 changes: 6 additions & 0 deletions samples/extensions/dynamic_rendering_local_read/dynamic_rendering_local_read.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,12 @@ class DynamicRenderingLocalRead : public ApiVulkanSample
int32_t attachment_width{0};
int32_t attachment_height{0};

std::array<uint32_t, 4> color_attachment_input_indices{VK_ATTACHMENT_UNUSED, 0, 1, 2};
VkRenderingInputAttachmentIndexInfo rendering_attachment_index_info{VK_STRUCTURE_TYPE_RENDERING_INPUT_ATTACHMENT_INDEX_INFO_KHR,
nullptr,
static_cast<uint32_t>(color_attachment_input_indices.size()),
color_attachment_input_indices.data()};

void setup_framebuffer() override;
void setup_render_pass() override;
void prepare_gui() override;
Expand Down
Loading