vkcubepp: Support Fuchsia#1079
Conversation
|
Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build. |
This change was originally in Fuchsia's Vulkan-Tools fork (https://fxrev.dev/441056). It adds Fuchsia OS (https://fuchsia.dev) support to vkcubepp. Fuchsia has two WSI platforms available: It can render directly to display frame buffer (fuchsia_display), or use Fuchsia's Scenic compositor (fuchsia_scenic). All Fuchsia-specific code is under VK_USE_PLATFORM_FUCHSIA ifdef build guards and is only compiled for Fuchsia targets. This change also adds a BUILD.gn file used for Fuchsia in-tree builds. Test: vkcube-on-fb and vkcube-on-scenic on Fuchsia Bug: https://fxbug.dev/378964821 Change-Id: Id4627bf209b4fc9400ce7f6847324cad2060c31c
gnoliyil
force-pushed
the
fuchsia-support
branch
from
a7dee95 to
3393c42
Compare
|
Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build. |
charles-lunarg
left a comment
charles-lunarg
left a comment
There was a problem hiding this comment.
Lots of code, but that is to be expected when supporting a new platform.
| ] | ||
| } | ||
|
|
||
| compiled_action("glslang_frag") { |
There was a problem hiding this comment.
FYI the spirv code is checked into the repo, so the GN build doesnt need to define it. Put another way, the shader compilation step is for developers of vkcube rather than those that wish to only build it. I am going to go ahead and merge it unmodified since it doesn't harm anyone to have the glslang compilation in GN.
3 participants
This change was originally in Fuchsia's Vulkan-Tools fork (https://fxrev.dev/441056). It adds Fuchsia OS
(https://fuchsia.dev) support to vkcubepp.
Fuchsia has two WSI platforms available: It can render directly to display frame buffer (
fuchsia_display), or use Fuchsia's Scenic compositor (fuchsia_scenic).All Fuchsia-specific code is under VK_USE_PLATFORM_FUCHSIA ifdef build guards and is only compiled for Fuchsia targets.
This change also adds a BUILD.gn file used for Fuchsia in-tree builds.
Test: vkcube-on-fb and vkcube-on-scenic on Fuchsia
Bug: https://fxbug.dev/378964821