Check for bad parameters on long vector type#4200
Open
dneto0 wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Check for bad parameters on long vector type#4200dneto0 wants to merge 1 commit intoKhronosGroup:mainfrom
dneto0 wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
Bug: crbug.com/486238211
Contributor
Author
|
cc: @dnovillo @jeffbolznv |
dnovillo
requested changes
Mar 30, 2026
| vector<float, 5, 7> excessCount; | ||
|
|
||
| vector() yep; | ||
| vector<void,5>() oof; |
Collaborator
There was a problem hiding this comment.
I can't access the original crbug (is there a way to change that?), but I don't think this will exercise the null-dereference. The vector() yep will produce a syntax error and it supresses any other diagnostics. Maybe something like this?
float a = vector<float>(0);
float b = vector<float,5,7>(0);
| bool isTensorViewNV() const { return basicType == EbtTensorViewNV; } | ||
|
|
||
| const TTypeParameters* getTypeParameters() const { return typeParameters; } | ||
| const TArraySizes* getArraySizes() const { return arraySizes; } |
Collaborator
There was a problem hiding this comment.
getArraySizes does not seem to be called anywhere. Remove?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: crbug.com/486238211