Check for bad parameters on long vector type

Test/baseResults/spv.longVectorBadParamsError.comp.out

@@ -0,0 +1,17 @@
+spv.longVectorBadParamsError.comp
+ERROR: 0:11: 'void' : invalid element type for vector 
+ERROR: 0:11: 'noElemType' : expected two type parameters 
+ERROR: 0:11: 'noElemType' : illegal use of type 'void' 
+ERROR: 0:12: 'void' : invalid element type for vector 
+ERROR: 0:12: 'badElemType' : illegal use of type 'void' 
+ERROR: 0:13: '' : vector type requires exactly 1 element count 
+ERROR: 0:13: 'missingCount' : expected two type parameters 
+ERROR: 0:14: '' : vector type requires exactly 1 element count 
+ERROR: 0:14: 'excessCount' : expected two type parameters 
+ERROR: 0:16: '' : vector type missing type parameters 
+ERROR: 0:16: '' : vector type missing type parameters 
+ERROR: 0:16: '' :  syntax error, unexpected IDENTIFIER, expecting COMMA or SEMICOLON
+ERROR: 12 compilation errors.  No code generated.
+
+
+SPIR-V is not generated for failed compile or link

Test/spv.longVectorBadParamsError.comp

@@ -0,0 +1,20 @@
+#version 450 core
+#extension GL_KHR_memory_scope_semantics : enable
+#extension GL_EXT_long_vector : enable
+#extension GL_EXT_shader_explicit_arithmetic_types : enable
+#extension GL_EXT_buffer_reference : enable
+#extension GL_EXT_expect_assume : enable
+
+
+void main()
+{
+    vector<5, 5> noElemType;
+    vector<void, 5> badElemType;
+    vector<float> missingCount;
+    vector<float, 5, 7> excessCount;
+
+    vector() yep;
+    vector<void,5>() oof;
+    vector<float>() blam;
+    vector<float,5,7>() borf;
+}

glslang/Include/Types.h

@@ -1567,6 +1567,9 @@ class TPublicType {
     bool isTensorLayoutNV() const { return basicType == EbtTensorLayoutNV; }
     bool isTensorViewNV() const { return basicType == EbtTensorViewNV; }
 
+    const TTypeParameters* getTypeParameters() const { return typeParameters; }
+    const TArraySizes* getArraySizes() const { return arraySizes; }
+
     void initType(const TSourceLoc& l)
     {
         basicType = EbtVoid;

glslang/MachineIndependent/ParseHelper.cpp

@@ -4668,6 +4668,10 @@ bool TParseContext::constructorError(const TSourceLoc& loc, TIntermNode* node, T
         return true;
     }
 
+    if (type.isLongVector() && !isValidLongVectorElseError(loc, type)) {
+        return true;
+    }
+
     if ((op != EOpConstructStruct && size != 1 && size < type.computeNumComponents()) ||
         (op == EOpConstructStruct && size < type.computeNumComponents())) {
         error(loc, "not enough data provided for construction", constructorString.c_str(), "");
@@ -8792,6 +8796,9 @@ void TParseContext::typeParametersCheck(const TSourceLoc& loc, const TPublicType
             return;
         }
     }
+    if (publicType.isLongVector() && !isValidLongVectorElseError(loc, publicType)) {
+        return;
+    }
 }
 
 bool TParseContext::vkRelaxedRemapUniformVariable(const TSourceLoc& loc, TString& identifier, const TPublicType& publicType,

glslang/MachineIndependent/ParseHelper.h

@@ -530,6 +530,32 @@ class TParseContext : public TParseContextBase {
     virtual void setAtomicCounterBlockDefaults(TType& block) const override;
     virtual void setInvariant(const TSourceLoc& loc, const char* builtin) override;
 
+    // Returns true if the given long vector type is correctly parameterized.
+    // Otherwise emits an error and returns false.
+    template<typename TTYPE>
+    bool isValidLongVectorElseError(const TSourceLoc& loc, const TTYPE& type) {
+        assert(type.isLongVector());
+        const TTypeParameters* typeParams = type.getTypeParameters();
+        if (typeParams == nullptr) {
+            error(loc, "vector type missing type parameters", "", "");
+            return false;
+        }
+        const auto basicType = typeParams->basicType;
+        if (!isTypeInt(basicType) && !isTypeFloat(basicType) && basicType != EbtBool) {
+            error(loc, "invalid element type for vector", TType::getBasicString(typeParams->basicType), "");
+            return false;
+        }
+        if (typeParams->arraySizes == nullptr) {
+            error(loc, "vector type missing element count", "", "");
+            return false;
+        }
+        if (typeParams->arraySizes->getNumDims() != 1) {
+            error(loc, "vector type requires exactly 1 element count", "", "");
+            return false;
+        }
+        return true;
+    }
+
 public:
     //
     // Generally, bison productions, the scanner, and the PP need read/write access to these; just give them direct access

gtests/Spv.FromFile.cpp

@@ -724,6 +724,7 @@ INSTANTIATE_TEST_SUITE_P(
         "spv.longVectorNotReserved.comp",
         "spv.longVectorSpecConst.comp",
         "spv.longVectorOperators.comp",
+        "spv.longVectorBadParamsError.comp",
         "spv.longVectorBuiltins.comp",
         "spv.longVectorBuiltinsfp16.comp",
         "spv.longVectorBuiltinsfp64.comp",