Restyle layout to not have panes overlay the stream #7806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
franknoirot
force-pushed
the
franknoirot/7222/inlaid-sidebar
branch
from
75b13d0 to
7235de9
Compare
CodSpeed Instrumentation Performance ReportMerging #7806 will not alter performanceComparing Summary
|
…lative ones at the fixture level Here's hoping!
Fix signature test; add makefile helper arg
Tested against main, so this is eligible for a breakout PR if we want. Revealed a gotcha with sketch mode state after direct code modifications.
I've reviewed this test and decided it is already covered by a combination of: 1. `e2e:desktop › sketch-tests.spec.ts › multi-profile sketching › can delete all profiles in sketch mode and user can still equip a tool and draw something` for the post-deletion behavior 2. `e2e:desktop › sketch-tests.spec.ts › multi-profile sketching › Can enter sketch loft edges, base and continue sketch` and others for the "sketch continuation" behavior
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This stemmed from our need to bias sketches over to the right because the left side of the sketch would be hidden beneath the code pane. Simply centering the sketch ensured that it was all in view at the start of entering sketch mode.
Thanks ML code review tools!
Most fragile test I've had so far I think. Made all the coordinates relative to the stream, but any camera tweaks will break this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #7222, providing a fix for the current user pain point of having their pane contents overlay the stream and block model visibility.
Draft until: