Skip to content

Restyle layout to not have panes overlay the stream #7806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 145 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 136 commits
Commits
Show all changes
145 commits
Select commit Hold shift + click to select a range
bf21d63
Make stream size based on container element, not window
franknoirot Jul 16, 2025
0e25661
Add a sixDot custom icon for a gripper
franknoirot Jul 16, 2025
752e338
Restyle layout to not have panes overlay stream
franknoirot Jul 16, 2025
19c1a3c
Update snapshots
github-actions[bot] Jul 16, 2025
7f0b3b8
Follow-up styling tweaks
franknoirot Jul 16, 2025
d45b8b9
Attempt to fix sketch mode rendering, something's still weird
franknoirot Jul 16, 2025
9401f0a
Update snapshots
github-actions[bot] Jul 16, 2025
53bfe8b
Use `offsetX` and Y instead of `clientX` and Y for mouse
franknoirot Jul 16, 2025
ff70ee4
Update snapshots
github-actions[bot] Jul 16, 2025
7235de9
use ResizeObserver for canvas resize
andrewvarga Jul 17, 2025
a806914
Tweak sidebar button styles to feel a bit nicer
franknoirot Jul 18, 2025
bed86d1
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Jul 18, 2025
db95046
Update snapshots
github-actions[bot] Jul 18, 2025
c7ab9d4
Try a quick fix of converting all page pixel coordinates to stream-re…
franknoirot Jul 18, 2025
bc0eae6
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Jul 21, 2025
eba877a
Update snapshot tests
franknoirot Jul 21, 2025
84d392e
Update snapshots
github-actions[bot] Jul 21, 2025
e9c610b
Don't start sketch before editing existing sketch
franknoirot Jul 21, 2025
9c1a9b4
Update "sketch on back sides" tests
franknoirot Jul 21, 2025
17ce979
Update snapshots
github-actions[bot] Jul 21, 2025
fb46d63
Update snapshots
github-actions[bot] Jul 21, 2025
e223807
Remove pixel color assertions from OBJ import test
franknoirot Jul 21, 2025
434cf92
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Jul 21, 2025
55353bf
Update click coordinates
franknoirot Jul 21, 2025
043f701
Fix toolbar button badge position
franknoirot Jul 21, 2025
bafe16c
Update moveNoWhere util to use canvas bbox
franknoirot Jul 21, 2025
19cf4af
Remove pixel coords from switching file test
franknoirot Jul 21, 2025
c748c89
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Jul 21, 2025
a2462de
Fix imported geometry tests by closing panes
franknoirot Jul 21, 2025
fdc473d
Remove coords from point-and-click assemblies tests
franknoirot Jul 21, 2025
72cf66c
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Jul 21, 2025
e445d27
Remove "extrude circle" test as it's tested a dozen other ways
franknoirot Jul 21, 2025
2daa53d
Remove 'can export from electron app' tests
franknoirot Jul 21, 2025
062ccf3
Remove coords from 'import from nested dir' test
franknoirot Jul 21, 2025
c386e7e
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Jul 21, 2025
10cde07
Update coords on abs dist constraint tests
franknoirot Jul 22, 2025
668fc69
Remove pixel-based selection regression test
franknoirot Jul 22, 2025
c6e4c99
Fix two issues with stream coordinates in tests
franknoirot Jul 22, 2025
32a0fbd
Update coords on stream resize test
franknoirot Jul 22, 2025
44f76fd
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Jul 22, 2025
5052b98
Update snapshots
github-actions[bot] Jul 22, 2025
a12229e
Remove pixel coords from 'nuke everything' sketch test
franknoirot Jul 22, 2025
4129491
lint and tsc
franknoirot Jul 22, 2025
c159309
Update pixel color check util to use transformed coords
franknoirot Jul 22, 2025
6be740e
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Jul 22, 2025
b8c34f4
Remove 'testing selections' tests that use pixel coords
franknoirot Jul 22, 2025
b6fffc8
Update `getGreatestPixDiff` to use relative coords
franknoirot Jul 22, 2025
813e2c6
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Jul 22, 2025
627e05b
Remove funky little pane UI regression E2E test
franknoirot Jul 23, 2025
14a5380
Reset snapshots to main and let CI update them accordingly
franknoirot Jul 23, 2025
0bb0ebe
Update snapshot test sketches to bias to origin instead of lower-righ…
franknoirot Jul 23, 2025
adbae7d
Update snapshots
github-actions[bot] Jul 23, 2025
5836bcf
Update camera movement test expected position
franknoirot Jul 23, 2025
0c33a57
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Jul 23, 2025
07dd00a
Update the coordinates for this little regression test
franknoirot Jul 23, 2025
40e1566
Update utils and comments
franknoirot Jul 23, 2025
e842552
Update coords in sketch on revolve face test
franknoirot Jul 23, 2025
2795878
Fix import from nested directory test
franknoirot Jul 23, 2025
2fa7d43
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
pierremtb Jul 24, 2025
8137314
Update coordinates for `Shift-click to select and deselect edges and …
pierremtb Jul 24, 2025
67e1479
Update snapshots
github-actions[bot] Jul 24, 2025
4a42d38
Fix import from nested directory test
franknoirot Jul 23, 2025
df2ffc8
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Jul 24, 2025
e31427d
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Jul 24, 2025
2eb124c
Clear containerElementRef on engine connection stop
franknoirot Jul 24, 2025
84a6ea5
Update snapshots
github-actions[bot] Jul 24, 2025
623a6ef
Update project test to not use pixel coords
franknoirot Jul 24, 2025
c84dc5f
Update snapshots
github-actions[bot] Jul 24, 2025
4c2a6f1
Update snapshots
github-actions[bot] Jul 25, 2025
0af5cd2
Improve project test after pixel coord removal
franknoirot Jul 25, 2025
6b710ee
Close code pane before clicking scene in "Create boolean operation --…
pierremtb Jul 25, 2025
afdddd9
Remove pixel coords from project switching "empty" test
franknoirot Jul 25, 2025
5669ed6
Remove pixel coords from file switch test with error
franknoirot Jul 25, 2025
f3947ca
Remove pixel coords from file switch test with empty file
franknoirot Jul 25, 2025
314b1a2
Remove pixel coords from non-English char project name test
franknoirot Jul 25, 2025
a6ff344
Refactor project colliding name test to not wait for scene
franknoirot Jul 25, 2025
1ca3ef2
Remove coord-based (via KCL) check from persistence test
franknoirot Jul 25, 2025
ead019b
Remove implicit coords from dragging / snapping test
franknoirot Jul 25, 2025
81b1de2
Update coords on double-click sketch test
franknoirot Jul 25, 2025
bfbe0c8
Update coords in continue a profile test
franknoirot Jul 25, 2025
ba0ed69
Remove unnecessary timeouts I added
franknoirot Jul 25, 2025
77d38f8
Try to fix drag helper to use stream-relative coords
franknoirot Jul 25, 2025
2afe1ba
Try to update coords in dragging test, still failing
franknoirot Jul 25, 2025
2869ef7
Use fixture helper to fix Revolve point-and-click
pierremtb Jul 25, 2025
eff0e50
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Jul 28, 2025
2884415
Scroll to the bottom of code in boolean tests, text is lazy
franknoirot Jul 28, 2025
995e714
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Jul 28, 2025
8ba9432
Lint
franknoirot Jul 28, 2025
7146ede
Update coords for chamfer tests
franknoirot Jul 28, 2025
a90c988
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Jul 28, 2025
94032e6
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Jul 30, 2025
65b715c
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Jul 31, 2025
2183027
Get rid of most uses of `getSegmentBodyCoords` in favor of `getBoundi…
franknoirot Jul 31, 2025
181b303
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Jul 31, 2025
a41533d
Update coords in selection test
franknoirot Jul 31, 2025
065e4c0
Remove fudge factor that is no longer necessary, so two seg test pass
franknoirot Jul 31, 2025
dd59330
Update coords and values for abs dist test set
franknoirot Jul 31, 2025
cf50638
Fix exit sketch test by closing code pane
franknoirot Jul 31, 2025
95f4ca2
Fix snap to close tests
franknoirot Jul 31, 2025
5938ce1
Fix test name formatting
franknoirot Jul 31, 2025
bf3a9d1
Try to fix up chamfer test on Linux
franknoirot Jul 31, 2025
49d846f
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Jul 31, 2025
f1f929d
Remove undo with code pane test in favor of step in another test
franknoirot Jul 31, 2025
b781db0
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Aug 1, 2025
d245392
Update snapshots
github-actions[bot] Aug 1, 2025
1b20593
Update snapshots
github-actions[bot] Aug 2, 2025
0ac9dc5
Update coordinates for gizmo center on selection test
franknoirot Aug 2, 2025
beca13d
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Aug 6, 2025
d325eba
lints and fmts
franknoirot Aug 6, 2025
7396ef7
Update snapshots
github-actions[bot] Aug 6, 2025
13ea92a
Update snapshots
github-actions[bot] Aug 6, 2025
ad50104
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Aug 6, 2025
221406b
Remove "basic-sketch" E2E tests
franknoirot Aug 6, 2025
502ac6f
Update snapshots
github-actions[bot] Aug 6, 2025
9709c89
Remove unnecessary E2E test
franknoirot Aug 6, 2025
9a61211
Lint
franknoirot Aug 7, 2025
65e74e9
Fix merge botch
franknoirot Aug 7, 2025
842eefb
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Aug 7, 2025
11f88c6
Update snapshots
github-actions[bot] Aug 7, 2025
aaab355
Remove absolute px scene checks in Fillet point-and-click delete
pierremtb Aug 7, 2025
0e49428
Update snapshots
github-actions[bot] Aug 7, 2025
882ca81
Keep only one px coordinate for sweepEdge selection in Fillet with la…
pierremtb Aug 7, 2025
d525419
Update snapshots
github-actions[bot] Aug 7, 2025
2ab49af
Remove redundant sketch test
jacebrowning Aug 7, 2025
9f87f1a
Keep only one px coordinate for sweepEdge selection in Fillet point-a…
pierremtb Aug 7, 2025
2ff52fb
Remove double setup step in Shift-click to select and deselect edges
pierremtb Aug 7, 2025
42286fb
Fix signature helper editor tests (#8006)
lee-at-zoo-corp Aug 7, 2025
83e3521
Fix network test (#8009)
lee-at-zoo-corp Aug 7, 2025
9ae9116
Fix "Verify axis, origin, and horizontal snapping" by adding a relati…
pierremtb Aug 8, 2025
f76c05e
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Aug 8, 2025
eb93d95
Update "delete all profiles" test to not draw the initial sketch
franknoirot Aug 8, 2025
6b2af69
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
franknoirot Aug 8, 2025
6f7c05e
Remove need for absolute coordinates in "Can undo a sketch modificati…
pierremtb Aug 8, 2025
5d16d91
Remove KCL and pixel-based checks from Snap to * tests
franknoirot Aug 8, 2025
2e565d3
Remove unnecessary old "delete most of the sketch" E2E test
franknoirot Aug 8, 2025
350e35e
Update Angle constraint test to make axis selection work again
franknoirot Aug 8, 2025
38c3da5
Update sketch profile in "remove constraints" E2E test
franknoirot Aug 8, 2025
9dee632
Remove absolute clicks in "Can delete a single segment line with keyb…
pierremtb Aug 8, 2025
9c0db12
Fix up my goofed RegExp strings in the Angle constraint tests
franknoirot Aug 8, 2025
fa95369
Update coordinates in stream-code highlight test
franknoirot Aug 8, 2025
b3a82d5
Merge branch 'main' into franknoirot/7222/inlaid-sidebar
pierremtb Aug 11, 2025
3aa0414
Restore original test name
jacebrowning Aug 12, 2025
36649dc
Move to common util and fix "Can edit a tangentialArc defined by angl…
pierremtb Aug 12, 2025
7a6b2ee
Merge branches 'franknoirot/7222/inlaid-sidebar' and 'franknoirot/722…
pierremtb Aug 12, 2025
bb1f26d
Bad: replace logic on exit sketch button with timeout in "can delete …
pierremtb Aug 12, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ run-desktop: install build ## Start the desktop app
###############################################################################
# TEST

PW_ARGS ?=

E2E_GREP ?=
E2E_WORKERS ?=
E2E_FAILURES ?= 1
Expand All @@ -138,17 +140,17 @@ test-e2e: test-e2e-$(TARGET)
.PHONY: test-e2e-web
test-e2e-web: install build ## Run the web e2e tests
ifdef E2E_GREP
npm run test:e2e:web -- --headed --grep="$(E2E_GREP)" --max-failures=$(E2E_FAILURES)
npm run test:e2e:web -- --headed --grep="$(E2E_GREP)" --max-failures=$(E2E_FAILURES) $(PW_ARGS)
else
npm run test:e2e:web -- --headed --workers='100%'
npm run test:e2e:web -- --headed --workers='100%' $(PW_ARGS)
endif

.PHONY: test-e2e-desktop
test-e2e-desktop: install build ## Run the desktop e2e tests
ifdef E2E_GREP
npm run test:e2e:desktop -- --grep="$(E2E_GREP)" --max-failures=$(E2E_FAILURES)
npm run test:e2e:desktop -- --grep="$(E2E_GREP)" --max-failures=$(E2E_FAILURES) $(PW_ARGS)
else
npm run test:e2e:desktop -- --workers='100%'
npm run test:e2e:desktop -- --workers='100%' $(PW_ARGS)
endif

.PHONY: test-snapshots
Expand Down
201 changes: 0 additions & 201 deletions e2e/playwright/basic-sketch.spec.ts

This file was deleted.

Loading
Loading