Skip to content

feat(TransformControlsWidget): add new widget #3280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

floryst
Copy link
Collaborator

@floryst floryst commented Jul 9, 2025

Results

Adds a TransformControlsWidget to control translation, rotation and scaling.

Translation:
image

Rotation:
image

Scaling:
image

Changes

  • Add vtkTorusSource
  • Add three widget representations for the three control modes
  • Add the vtkTransformControlsWidget
  • Add vtkProp3D.setOrientationFromQuaternion
  • Add typescript definitions
  • Add example screenshots

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@floryst floryst requested review from finetjul and sankhesh July 9, 2025 18:12
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a screenshot/gif in the example gallery documentation

@finetjul
Copy link
Member

Great job !

Could all 3 operations could be done all at once ?

@floryst
Copy link
Collaborator Author

floryst commented Jul 28, 2025

Could all 3 operations could be done all at once ?

Yes, but I didn't add that functionality to reduce clutter. In particular, we'll need to adjust the handle management when supporting both translation and scaling being enabled at the same time. That can be something for future work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants