-
-
Notifications
You must be signed in to change notification settings - Fork 394
feat(TransformControlsWidget): add new widget #3280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a screenshot/gif in the example gallery documentation
Sources/Widgets/Representations/TranslateTransformHandleRepresentation/TransformHandleSource.js
Show resolved
Hide resolved
Sources/Widgets/Widgets3D/TransformControlsWidget/example/index.js
Outdated
Show resolved
Hide resolved
Great job ! Could all 3 operations could be done all at once ? |
Yes, but I didn't add that functionality to reduce clutter. In particular, we'll need to adjust the handle management when supporting both translation and scaling being enabled at the same time. That can be something for future work. |
Results
Adds a TransformControlsWidget to control translation, rotation and scaling.
Translation:

Rotation:

Scaling:

Changes
vtkProp3D.setOrientationFromQuaternion
PR and Code Checklist
npm run reformat
to have correctly formatted codeTesting