Skip to content

feat(ShrinkPolyData): add vtkShrinkPolyData #3291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2025
Merged

feat(ShrinkPolyData): add vtkShrinkPolyData #3291

merged 1 commit into from
Aug 12, 2025

Conversation

daker
Copy link
Collaborator

@daker daker commented Jul 21, 2025 •
edited
Loading

Context

Results

image

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@daker daker force-pushed the feat-shrinkpolydata branch from 2f2a859 to 01d527d Compare July 21, 2025 13:00
finetjul
finetjul requested changes Jul 21, 2025
View reviewed changes
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a screenshot and add it to the gallery.

@daker daker force-pushed the feat-shrinkpolydata branch from 01d527d to 8b773a0 Compare July 21, 2025 15:14
@daker daker requested a review from finetjul July 21, 2025 15:15
@daker daker force-pushed the feat-shrinkpolydata branch from 8b773a0 to 645e2b2 Compare July 21, 2025 16:31
@daker
Copy link
Collaborator Author

daker commented Jul 21, 2025

Please add a screenshot and add it to the gallery.

Done

@daker daker force-pushed the feat-shrinkpolydata branch from 645e2b2 to 81b4eaa Compare July 21, 2025 16:37
@daker
Copy link
Collaborator Author

daker commented Jul 22, 2025

@finetjul Do you have time for another review ?

finetjul
finetjul requested changes Jul 22, 2025
View reviewed changes
@daker daker force-pushed the feat-shrinkpolydata branch 7 times, most recently from 19bca33 to f9c8c68 Compare July 23, 2025 16:42
@daker daker requested a review from finetjul July 23, 2025 16:42
@daker
Copy link
Collaborator Author

daker commented Jul 28, 2025

@finetjul mind looking again if you have time ?

finetjul
finetjul reviewed Jul 28, 2025
View reviewed changes
@daker daker force-pushed the feat-shrinkpolydata branch from f9c8c68 to ac43387 Compare July 28, 2025 09:16
@daker daker force-pushed the feat-shrinkpolydata branch from ac43387 to df7d307 Compare July 28, 2025 10:15
@daker daker mentioned this pull request Jul 28, 2025
Open
5 tasks
finetjul
finetjul approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sankhesh sankhesh added this pull request to the merge queue Aug 12, 2025
Merged via the queue into Kitware:master with commit becef28 Aug 12, 2025
2 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 34.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Aug 12, 2025
@daker daker deleted the feat-shrinkpolydata branch August 12, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finetjul finetjul finetjul approved these changes

Assignees
No one assigned
Labels
released Automated label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daker @finetjul @sankhesh