ENH: Add template support for defining application display name #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike "APPLICATION_NAME", "APPLICATION_DISPLAY_NAME" can contain space characters. Compatible with Slicer/Slicer@8e30ae8.
jamesobutler
force-pushed
the
application-display-name
branch
from
ae7a8c3 to
6249b86
Compare
jcfr
approved these changes
Sep 18, 2025
Collaborator
|
@jamesobutler Is this ready for integration ? |
Contributor
Author
|
Yes. I had just updated the last commit with some files specific to custom apps so that they would also use the applicationDisplayName property. I confirmed these changes using my own Slicer custom app. Should be good to go 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds templating support for defining the "APPLICATION_DISPLAY_NAME" which is compatible with the changes in Slicer/Slicer#8731.
Unlike "APPLICATION_NAME", "APPLICATION_DISPLAY_NAME" can contain space characters.
Compatible with Slicer/Slicer@8e30ae8.