feat: add a Dockerfile #23
Conversation
|
Can you please add a non WSL dockerfile ? Related to: #17 |
docker/Dockerfile_WSL
Outdated
| @@ -0,0 +1,26 @@ | |||
| FROM python:3.10-slim | |||
There was a problem hiding this comment.
why 3.10 and not a more recent version?
There was a problem hiding this comment.
trame-slicer is currently limited to 3.10 because of the available vtk MRML wheels.
docker/README
Outdated
| - To use EGL: | ||
|
|
||
| `docker run -p 8080:8080 -it --gpus all -e VTK_DEFAULT_OPENGL_WINDOW=vtkEGLRenderWindow -e LD_LIBRARY_PATH=/usr/lib/wsl/lib -v /usr/lib/wsl:/usr/lib/wsl trame-slicer-wsl` | ||
|
|
||
| - To use X server: | ||
|
|
||
| `docker run -p 8080:8080 -it --gpus all -e DISPLAY -e LD_LIBRARY_PATH=/usr/lib/wsl/lib -v /usr/lib/wsl:/usr/lib/wsl -v /tmp/.X11-unix:/tmp/.X11-unix trame-slicer-wsl` |
There was a problem hiding this comment.
probably missing some host requirements here, I can't get it to work on my windows 10 WSL. It's always using llvmpipe. I have nvidia drivers installed and able to use my GPU inside WSL.
|
Thx for the PR! Regarding the PR, could you amend the commit to replace feat by doc as we don't want to trigger a new minor release for this dockerfile? 🙏 |
Jo-Byr
force-pushed
the
docker
branch
2 times, most recently
from
6d4af77 to
3d29699
Compare
Thibault-Pelletier
force-pushed
the
main
branch
3 times, most recently
from
7060d84 to
86fd515
Compare
Thibault-Pelletier
force-pushed
the
main
branch
2 times, most recently
from
e94ad01 to
b07b3d4
Compare
|
I rebased the branch and modified the approach. It seems to work correctly on both WSL and Linux, but it seems the X / EGL toggle does nor work as intended. |
|
|
||
| The run command depends on the image: | ||
|
|
||
| - WSL |
There was a problem hiding this comment.
how about adding instructions for CPU (Mesa) rendering.
There was a problem hiding this comment.
Should I also remove X render instructions as discussed ?
There was a problem hiding this comment.
For X, the thing is that you manage to get it to work in another project, so the problem does not seem to come from the docker image. Maybe you can document something like that: the docker image is known to work with a X server, yet no instruction is provided)
There was a problem hiding this comment.
I added MESA instructions and a warning for X server on WSL. I was able to make it work on Linux.
No description provided.