add a todo regarding session properties not existing in the spec #7
Conversation
|
oops we can actually have issues in this repo: https://stackoverflow.com/questions/16406180/is-there-a-way-to-add-issues-to-a-github-forked-repo-without-modifying-the-orig @borngraced @shamardy |
done |
| // TODO: There doesn't seem to be a sessionProperties field as per the spec: https://specs.walletconnect.com/2.0/specs/clients/sign/rpc-methods#wc_sessionsettle | ||
| // Instead, there is an optional specialNamespaces field that's missing. |
There was a problem hiding this comment.
some implementations uses it like keplr WalletConnect
There was a problem hiding this comment.
but why isn't such a field in the spec??
i found a field with the same name somewhere else but it already has a completely different data/structure.
There was a problem hiding this comment.
hmmm...session_properties takes an arbitrary value, so it's unto you to know what the wallet you're targeting includes in theirs
Wanted to flag it as an issue but looks like we can't have issues in forked repo.
So leaving it as an inline todo for now.