Skip to content

add a todo regarding session properties not existing in the spec #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: kdf
Choose a base branch
from
Open

add a todo regarding session properties not existing in the spec #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions relay_rpc/src/rpc/params/session_settle.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ pub struct SessionSettleRequest {
///
/// Expiry should be between .now() + TTL.
pub expiry: u64,
// TODO: There doesn't seem to be a sessionProperties field as per the spec: https://specs.walletconnect.com/2.0/specs/clients/sign/rpc-methods#wc_sessionsettle
// Instead, there is an optional specialNamespaces field that's missing.
Comment on lines +40 to +41
Copy link
Collaborator

@borngraced borngraced Jun 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some implementations uses it like keplr WalletConnect

Copy link
Collaborator Author

@mariocynicys mariocynicys Jun 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but why isn't such a field in the spec??
i found a field with the same name somewhere else but it already has a completely different data/structure.

Copy link
Collaborator

@borngraced borngraced Jun 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm...session_properties takes an arbitrary value, so it's unto you to know what the wallet you're targeting includes in theirs

pub session_properties: Option<Value>,
}

Expand Down
Loading