Fix layout of KDateTimePicker time inputs to be on the same row #2903
+55
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordojordo
requested review from
a team,
Justineo,
adamdehaven and
jillztom
as code owners
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jordojordo
force-pushed
the
fix/ma-4310
branch
from
af10076 to
d4c20ce
Compare
Collaborator
Preview package from this PR in consuming applicationIn consuming application project install preview version of kongponents generated by this PR: |
Member
|
@jordojordo is this pull request still valid or can it be closed? |
Member
Author
|
@adamdehaven Yes it can be closed, the work has been done elsewhere. Thanks for the nudge 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix MA-4310
This will re-order the layout of the time inputs within the
KDateTimePickercomponent to put them on the same row instead of stacking.Also a small docs fix to the contributing section on how to run the sandbox.
Before
After