Skip to content

Fix layout of KDateTimePicker time inputs to be on the same row #2903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jordojordo wants to merge 2 commits into from
+55 −47
Closed

Fix layout of KDateTimePicker time inputs to be on the same row #2903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd2936b
docs: update contributing sandbox reference [MA-4310]
jordojordo Sep 15, 2025
d4c20ce
fix(kdatetimepicker): layout time inputs on same row [MA-4310]
jordojordo Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/guide/contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ The sandbox mode in Kongponents provides developers with a controlled environmen
By using the sandbox mode, you can have confidence that components maintain their visual consistency, regardless of the context in which they are used.

```sh
pnpm dev:sandbox
pnpm sandbox:dev
```

## Committing Changes
Expand Down
100 changes: 54 additions & 46 deletions src/components/KDateTimePicker/CalendarWrapper.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,49 +18,51 @@
v-if="showTime"
class="time-wrapper"
>
<div
class="time-input"
>
<label
class="time-input-label"
:for="`time-input-start-${componentId}`"
>
<span v-if="showRange('start')">
<!-- @vue-ignore: typeguard in showRange -->
{{ formatDateDisplay(calendarVModel.start) }}
</span>
<span v-else-if="(calendarVModel && calendarVModel instanceof Date)">
{{ formatDateDisplay(calendarVModel) }}
</span>
</label>
<input
:id="`time-input-start-${componentId}`"
v-model="startTimeValue"
class="time-input-start"
:class="{ 'input-error': hasError }"
data-testid="time-input-start"
:step="60"
type="time"
>
<label
class="time-input-label"
:for="`time-input-end-${componentId}`"
>
<span v-if="showRange('end')">
<!-- @vue-ignore: typeguard in showRange -->
{{ format(calendarVModel.end, 'EEE MMM d yyyy') }}
</span>
</label>
<input
v-if="isRange"
:id="`time-input-end-${componentId}`"
v-model="endTimeValue"
class="time-input-end"
:class="{ 'input-error': hasError }"
data-testid="time-input-end"
:step="60"
type="time"
>
<div class="time-input">
<div class="time-input-item">
<label
class="time-input-label"
:for="`time-input-start-${componentId}`"
>
<span v-if="showRange('start')">
<!-- @vue-ignore: typeguard in showRange -->
{{ formatDateDisplay(calendarVModel.start) }}
</span>
<span v-else-if="(calendarVModel && calendarVModel instanceof Date)">
{{ formatDateDisplay(calendarVModel) }}
</span>
</label>
<input
:id="`time-input-start-${componentId}`"
v-model="startTimeValue"
class="time-input-start"
:class="{ 'input-error': hasError }"
data-testid="time-input-start"
:step="60"
type="time"
>
</div>
<div class="time-input-item">
<label
class="time-input-label"
:for="`time-input-end-${componentId}`"
>
<span v-if="showRange('end')">
<!-- @vue-ignore: typeguard in showRange -->
{{ format(calendarVModel.end, 'EEE MMM d yyyy') }}
</span>
</label>
<input
v-if="isRange"
:id="`time-input-end-${componentId}`"
v-model="endTimeValue"
class="time-input-end"
:class="{ 'input-error': hasError }"
data-testid="time-input-end"
:step="60"
type="time"
>
</div>
</div>
<Transition
mode="out-in"
Expand Down Expand Up @@ -229,10 +231,16 @@ defineExpose({
.time-input {
border-radius: var(--kui-border-radius-10, $kui-border-radius-10);
display: flex;
flex-direction: column;
gap: var(--kui-space-30, $kui-space-30);
flex-direction: row;
justify-content: space-between;
padding: var(--kui-space-30, $kui-space-30) var(--kui-space-60, $kui-space-60);
width: fit-content;

.time-input-item {
display: flex;
flex-direction: column;
gap: var(--kui-space-30, $kui-space-30);
width: min-content;
}

input[type="time"] {
@include inputDefaults;
Expand Down