Expose RpcServiceDescriptor.callableMap #503
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he test input files
rnett
commented
Oct 8, 2025
|
@rnett Sorry, it was accidentally closed. Please rebase it on |
|
Also, do you think we can finish it this week so we can release 0.10.1 with it on the next? |
Mr3zee
reviewed
Oct 14, 2025
...in/compiler-plugin-backend/src/main/kotlin/kotlinx/rpc/codegen/extension/RpcStubGenerator.kt
Show resolved
Hide resolved
...in/compiler-plugin-backend/src/main/kotlin/kotlinx/rpc/codegen/extension/RpcStubGenerator.kt
Show resolved
Hide resolved
core/src/commonMain/kotlin/kotlinx/rpc/descriptor/RpcServiceDescriptor.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Descriptors.
Problem Description
See #496. Despite generating a list of a descriptor's callables, it's never exposed.
Solution
This PR makes the generated property public and adds a corresponding overridden property to the interface.
ATTENTION
I don't have the necessary permissions to update labels.
ApiVersioningTesthas some failures but they are present ondevelopment, too.