Spectrum fitting for activation foils#71
Merged
RemDelaporteMathurin merged 44 commits intomainfrom May 16, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 84.49% 84.74% +0.25%
==========================================
Files 18 18
Lines 1193 1331 +138
==========================================
+ Hits 1008 1128 +120
- Misses 185 203 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
Member
Author
There was a problem hiding this comment.
please ignore this file it's just for showing some of the usage for now
cdunn314
suggested changes
May 15, 2025
Contributor
cdunn314
left a comment
There was a problem hiding this comment.
I didn't test the code but I did look through most of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reimplements what was proposed by @cdunn314 in #47
It adds new objects:
CheckSource: is composed of aNuclide, an activity date, and an activityDetector: has achannel_nb, holds the events (time and energies) as well as the count times (real and live)Measurement: is composed of severalDetector, and has a start and stop time. Can also be used for background measurements.CheckSourceMeasurement: is a child class ofMeasurement, and has aCheckSourceattached to it. It is useful to compute the detection efficiency of detectorsI also moved almost everything to
compass.pyto avoid circular importsI've also tried to test as much as possible. Tests can probably be simplified in some cases but I'm happy to refactor tests in a future PR.
Next steps (in future PRs) will hopefully close the analysis:
Measurement)