Skip to content

fix: undeprecate fetchPKPsThroughRelayer for browser environments #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: undeprecate fetchPKPsThroughRelayer for browser environments #816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/lit-auth-client/src/lib/providers/BaseProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@ export abstract class BaseProvider {
}

/**
* @deprecated - Use {@link fetchPKPs} instead
* Fetch PKPs associated with given auth method from relay server
* Fetch PKPs associated with given auth method from relay server.
* This is the preferred method for browser environments to avoid wallet popups.
*
* @param {AuthMethod} authMethod - Auth method object
*
Expand All @@ -130,7 +130,6 @@ export abstract class BaseProvider {
public async fetchPKPsThroughRelayer(
authMethod: AuthMethod
): Promise<IRelayPKP[]> {
deprecated('fetchPKPsThroughRelayer is deprecated. Use fetchPKPs instead.');
const data = await this.prepareRelayRequestData(authMethod);
const body = this.prepareFetchBody(data);
const fetchRes = await this.relay.fetchPKPs(body);
Expand Down Expand Up @@ -219,7 +218,9 @@ export abstract class BaseProvider {
}

/**
* Fetch PKPs associated with given auth method from pkp contract
* Fetch PKPs associated with given auth method from pkp contract.
* Note: Not recommended for browser environments as it may trigger wallet popups.
* Use {@link fetchPKPsThroughRelayer} instead for browser environments.
*
* @param {AuthMethod} authMethod - Auth method object
*
Expand Down
Loading