Skip to content

feat: style discussion section in modal with heading and background #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdmueller merged 1 commit into from
Mar 18, 2026
Merged

feat: style discussion section in modal with heading and background #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions website/src/components/anchor-modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { i18n } from '../i18n.js'
import { fetchAnchorsData, fetchFeedbackData } from '../utils/data-loader.js'
import { getRouteBeforeModal, getScrollBeforeModal } from '../utils/router.js'

Check warning on line 3 in website/src/components/anchor-modal.js

View workflow job for this annotation

GitHub Actions / Lint & Format Check 

'getScrollBeforeModal' is defined but never used

let asciidoctor = null

Expand Down Expand Up @@ -311,6 +311,12 @@
if (fb.recentComments && fb.recentComments.length > 0) {
const commentsHtml = `
<div class="feedback-section">
<h4 class="feedback-heading">
<svg class="w-4 h-4" fill="none" stroke="currentColor" viewBox="0 0 24 24">
<path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M7 8h10M7 12h4m1 8l-4-4H5a2 2 0 01-2-2V6a2 2 0 012-2h14a2 2 0 012 2v8a2 2 0 01-2 2h-3l-4 4z"></path>
</svg>
${i18n.t('feedback.discussionHeading')}
</h4>
<div class="feedback-comments">
${fb.recentComments
.map(
Expand Down
9 changes: 8 additions & 1 deletion website/src/styles/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,14 @@ body {

/* Feedback section in anchor modal (comments area) */
.feedback-section {
@apply mt-8 pt-6 border-t border-gray-200 dark:border-gray-700;
@apply mt-8 p-4 rounded-lg;
@apply bg-gray-50 dark:bg-gray-800/50;
@apply border border-gray-200 dark:border-gray-700;
}

.feedback-heading {
@apply flex items-center gap-2 text-sm font-semibold mb-3;
@apply text-gray-500 dark:text-gray-400;
}

.feedback-actions {
Expand Down
1 change: 1 addition & 0 deletions website/src/translations/de.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,5 +61,6 @@
"feedback.vote": "Abstimmen",
"feedback.discuss": "Diskutieren",
"feedback.cta": "Ist dieser Anker hilfreich?",
"feedback.discussionHeading": "Community-Diskussion",
"feedback.requiresLogin": "Erfordert GitHub-Login"
}
1 change: 1 addition & 0 deletions website/src/translations/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,5 +61,6 @@
"feedback.vote": "Vote",
"feedback.discuss": "Discuss",
"feedback.cta": "Is this anchor useful?",
"feedback.discussionHeading": "Community Discussion",
"feedback.requiresLogin": "Requires GitHub login"
}
Loading