This repository was archived by the owner on Nov 23, 2020. It is now read-only.
[Feature][0.9][Merged] Alert messages can now have HTML content #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabacitu
commented
Feb 28, 2018
| border-color: #f8d053; | ||
| } | ||
|
|
||
| /* FLEXBOX HELPERS */ |
There was a problem hiding this comment.
This has NOTHING to do with the current PR, but it's needed and harmless, so I say let's leave it.
tabacitu
changed the title
lloy0076
reviewed
Mar 5, 2018
| border-color: #f8d053; | ||
| } | ||
|
|
||
| /* FLEXBOX HELPERS */ |
| new PNotify({ | ||
| // title: 'Regular Notice', | ||
| text: "{{ $message }}", | ||
| text: "{!! str_replace('"', "'", $message) !!}", |
There was a problem hiding this comment.
There was a problem hiding this comment.
Yup. Just double-checked to be sure: https://cl.ly/3C2V1s0i1Y26
7 tasks
|
Merged into upgrade branch #259 . We'll leave this PR and branch open, and push fixes here if anything comes up in testing. |
tabacitu
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that you can do things like:
This is NOT a breaking change, it's backwards-compatible, but we should make sure we don't use this feature ourselves in the code, until it's adopted. For this reason, I think it should be launched with the 3.4 update.