This repository was archived by the owner on Nov 23, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 271
[Release][WIP] Base 0.9 Upgrade #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…envanhee/Base into jorenvanhee-different-user-model-issue-fix
…Laravel-Backpack/Base into publish-minimum-amount-of-files
…ack/Base into custom-routes-file
lloy0076
reviewed
Mar 8, 2018
src/BaseServiceProvider.php
Outdated
*/ | ||
private function checkLicenseCodeExists() | ||
{ | ||
if (! env('BACKPACK_LICENSE')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't that be in a config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. Totally! Done, thank you!
[Feature][0.9][Ready] AdminLTE update
BOOM!It's done :-) tested, merged, tagged and launched. See: Thank you so much for all the help, guys! This has been a HUGE effort. |
nice :____ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is here to document all major changes between 0.8.x and 0.9.x. It will help us easily detect breaking changes, document them, and create the upgrade guide.
PRs
@section
Upgrade guide
admin
middleware withbackpack_middleware()
helper. By default, Backpack used a middleware calledadmin
to allow/deny access to admin pages. This middleware name can now be customized inconfig/backpack/base.php
. To future-proof your applications, it's recommended that you change this middleware name everywhere you've used it, to the newbackpack_middleware()
helper that automatically pulls the name (check your routes and controllers).admin
middleware's class has been renamed toCheckIfAdmin
; if you were extendingBackpack\Base\app\Http\Middleware\Admin
anywhere, make sure to extend the new class name:Backpack\Base\app\Http\Middleware\CheckIfAdmin
;backpack_auth()
helper instead of Laravel's defaultAuth
facade, so that if any custom guards are specified inconfig/backpack/base.php
, they're taken into account; So if you've used something likeAuth::user()
anywhere in an admin panel controller/model/view/request, please replace withbackpack_auth->user()
; we've replaced this ourselves in the following files:sidemenu.blade.php
,menu.blade.php
,sidebar.blade.php
,sidebar_user_panel.blade.php
; make sure you apply the changes if you've overwritten them; if you've never ever modified those files, but they're in yourresources/views/vendor/backpack/base
folder, just delete them from there, and Backpack will pick up the fresh files from the package folder instead; you can also use thebackpack_guard()
helper if you need the guard name anywhere;sidebar.blade.php
to hold all our sidebar items. We've moved that to a file calledsidebar_content.blade.php
, so that you can also automatically generate sidebar items; Please create a new file calledsidebar_content.blade.php
and copy all your sidebar items there, then either delete yoursidebar.blade.php
file or replace the old sidebar items with@include('backpack::inc.sidebar_content')
; take a look here for an example in code;sidebar_content.blade.php
). If you have views inresources\views\vendor\backpack\base
that you have never modified, please remove them (especiallylayout.blade.php
); This will make sure you benefit from any updates we push, further down the line; Backpack will pick up the new files from the package folder, automatically;resources/views/vendor/backpack/inc/alerts.blade.php
file; Backpack will automatically pick up the original file from the package afterwards;routes/backpack/custom.php
. That's whereCRUD::resource()
routes are generated automatically, when you generate a new CRUD. To future-proof your application, you can publish that file usingphp artisan vendor:publish --provider="Backpack\Base\BaseServiceProvider" --tag=custom_routes
, then manually move your existing admin routes there (from yourroutes/web.php
.