chore: add rewards v2.2 comprehensive unit/integration/Anvil tests #490

serichoi65 · 2026-01-06T21:53:17Z

Description

Summary

Adds comprehensive unit, integration, and Anvil tests for Rewards v2.2 (PRs #476, #481), validating operator allocation snapshots, withdrawal queue logic, and refund calculations. All tests passing with 100% coverage of edge cases defined in the Rewards V2.2 Testing Plan.

Test Coverage

OAS (Operator Allocation Snapshots) - 17 scenarios:

OAS-1 to OAS-3: Basic allocation rounding (UP for allocations, DOWN for deallocations)
OAS-4 to OAS-9: Same-day allocation changes, effective block delays
OAS-10 to OAS-14: Max magnitude updates, slashing simulations
OAS-15 to OAS-17: Multi-strategy allocations, future block scenarios

SSS (Staker Share Snapshots) - 15 scenarios:

SSS-1 to SSS-7: Withdrawal queue timing (14-day delay)
SSS-8 to SSS-11: Slashing during withdrawal queue
SSS-12 to SSS-15: Same-block events (withdrawal + slash log ordering), dual slashing

R (Refunds) - 4 scenarios:

R-1: Full period refund (no allocation)
R-2: Partial refund (allocation starts mid-period)
R-3: Post-deallocation refund
R-4: Multi-operator proportional distribution

Integration Tests (8 Scenarios - PostgreSQL):

Scenario 1: Forward-looking rewards with withdrawal during period
Scenario 2: Multiple concurrent withdrawals
Scenario 3: Slash during withdrawal queue
Scenario 4: 2-year forward-looking rewards
Scenario 5: Deallocation queue (operator unique stake)
Scenario 6: Undelegation with slashing (TC4)
Scenario 7: Withdrawal queue with deallocation
Scenario 8: Withdrawal completing at reward period end

Anvil Tests (10 Scenarios - Real Contract Events):

Tier 2 and Tier 3 tests with actual AllocationManager events
Validates event ingestion and snapshot generation
Configured for PreprodHoodi environment

Bug Fixes & Improvements

Schema Corrections:

Fixed blocks table inserts (removed non-existent columns)
Fixed operator_allocations inserts (removed avs_directory, block_time)
Fixed staker_shares inserts (aligned with migration schema)
Fixed reward_submissions and operator_set_operator_registrations schemas

Snapshot Timing Logic:

Corrected off-by-one errors (events on 1/5 appear in 1/6 snapshot)
Fixed withdrawal queue timing (14-day inclusive/exclusive logic)
Adjusted all test expectations to match block_date < snapshot_date logic

Linter Fixes:

Fixed unchecked error returns in rewardsV2_2_anvil_test.go (10 instances)
Removed unused variables across test files
Fixed timezone comparison issues (using formatted strings)

Chain Configuration:

Updated all tests to use Chain_PreprodHoodi
Verified Sabine fork configuration (1970-01-01 for preprod environments)

Notes

Legacy tests in stakerShareSnapshots_test.go intentionally skipped (incompatible with continuous daily snapshot generation)
Test database automatically created/dropped for isolation
Anvil tests require REWARDS_COORDINATOR_ADDRESS and ALLOCATION_MANAGER_ADDRESS environment variables

Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (non-breaking change which does not add functionality)

How Has This Been Tested?

Unit tests

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules
I have checked my code and corrected any misspellings

pkg/rewards/operatorAllocationSnapshots_test.go

pkg/rewards/stakerShareSnapshots_test.go

anupsv · 2026-01-09T19:39:42Z

pkg/rewards/stakerShareSnapshots.go

+		INNER JOIN blocks b_queued ON qsw.block_number = b_queued.number
+		WHERE
+			-- Still within withdrawal queue window (not yet completable)
+			b_queued.block_time + INTERVAL '{{.withdrawalQueueWindow}} days' > TIMESTAMP '{{.snapshotDate}}'


is the source of the .withdrawalQueueWindow from event emission ?

The withdrawalQueueWindow is a configuration value (r.globalConfig.Rewards.WithdrawalQueueWindow), not from event emission. It's set to 14 days for mainnet.

pkg/rewards/15_goldOperatorOperatorSetUniqueStakeRewards.go

pkg/rewards/stakerShareSnapshots_test.go

pkg/eigenState/precommitProcessors/slashingProcessor/slashing.go

pkg/eigenState/precommitProcessors/slashingProcessor/createSlashingAdjustments_test.go

pkg/eigenState/precommitProcessors/slashingProcessor/slashing.go

pkg/eigenState/precommitProcessors/slashingProcessor/createSlashingAdjustments_test.go

pkg/rewards/stakerShareSnapshots_test.go

pkg/eigenState/precommitProcessors/slashingProcessor/slashing_test.go

pkg/eigenState/precommitProcessors/slashingProcessor/slashing.go

ypatil12 · 2026-01-22T02:51:39Z

pkg/eigenState/precommitProcessors/slashingProcessor/slashing.go

 			) * (1 - LEAST(@wadSlashed / 1e18, 1)) as slash_multiplier,
 			@blockNumber as block_number,
 			@transactionHash as transaction_hash,
 			@logIndex as log_index


Since this query is selecting from queued_slashing_withdrawal table, which hasn't been committed yet (ie. latest block not updated), could we have a staleness issue? Edge case: a withdrawal has been queued in this block and then we are slashed a couple times in the same block. Do we need to add accumulated withdrawals in the given block? cc @elhajin

Slashes on day X now correctly become visible for snapshots on day X+1, matching the spec rule: block_date < snapshot_date

serichoi65 requested a review from a team as a code owner January 6, 2026 21:53

serichoi65 requested review from 0xrajath and seanmcgary and removed request for a team January 6, 2026 21:53

serichoi65 force-pushed the rewards-v2.2-tests branch 3 times, most recently from 2701725 to 9401b5f Compare January 7, 2026 14:27

serichoi65 changed the title ~~feat: add comprehensive unit/anvil/integration tests~~ feat: add rewards v2.2 comprehensive unit/integration/Anvil tests Jan 7, 2026

serichoi65 changed the title ~~feat: add rewards v2.2 comprehensive unit/integration/Anvil tests~~ fix/chore: add rewards v2.2 comprehensive unit/integration/Anvil tests Jan 7, 2026

serichoi65 changed the title ~~fix/chore: add rewards v2.2 comprehensive unit/integration/Anvil tests~~ chore: add rewards v2.2 comprehensive unit/integration/Anvil tests Jan 7, 2026

ypatil12 reviewed Jan 8, 2026

View reviewed changes

serichoi65 force-pushed the seri.choi/rewards-v2.2 branch from cefb196 to 1f2fde9 Compare January 8, 2026 16:29

Base automatically changed from seri.choi/rewards-v2.2 to master January 8, 2026 17:01

anupsv reviewed Jan 9, 2026

View reviewed changes

pkg/rewards/15_goldOperatorOperatorSetUniqueStakeRewards.go Outdated Show resolved Hide resolved

serichoi65 added 6 commits January 12, 2026 21:44

feat: add comprehensive unit/anvil/integration tests

1e0e512

update fork dates for testnet

03b6b76

update OAS

c1b41dc

update SSS tests

a588ddc

CSA and SSS_anvil tests

a15ec95

upgrade preprod-hoodi rewards coordinator implementation address

a84982c

serichoi65 force-pushed the rewards-v2.2-tests branch from 5751bbc to 5395626 Compare January 13, 2026 02:45

go fmt

ab00045

serichoi65 force-pushed the rewards-v2.2-tests branch from 5395626 to ab00045 Compare January 13, 2026 03:00

anvil

8c9826c

serichoi65 force-pushed the rewards-v2.2-tests branch from 7694397 to 8c9826c Compare January 13, 2026 17:15

serichoi65 added 2 commits January 13, 2026 14:23

fix SSS tests

a22c1f2

lint

ee10653

serichoi65 force-pushed the rewards-v2.2-tests branch from f9fccf7 to ee10653 Compare January 13, 2026 19:31

fork override and more tests

03175c7

serichoi65 force-pushed the rewards-v2.2-tests branch from ebc358e to 03175c7 Compare January 13, 2026 20:03

serichoi65 added 2 commits January 13, 2026 17:05

fix SSS tests

04e4c72

clean tests

71ab54f

ypatil12 reviewed Jan 16, 2026

View reviewed changes

serichoi65 force-pushed the rewards-v2.2-tests branch from fdfb4ce to 8c6c1eb Compare January 21, 2026 19:28

ypatil12 reviewed Jan 22, 2026

View reviewed changes

calculate add-back with day-specific slash visibility

9aab10c

Slashes on day X now correctly become visible for snapshots on day X+1, matching the spec rule: block_date < snapshot_date

serichoi65 force-pushed the rewards-v2.2-tests branch from 8c6c1eb to 9aab10c Compare January 22, 2026 17:18

serichoi65 added 3 commits January 22, 2026 12:45

fix SSS

16a9ecc

update fork date

aab6121

remove

15c7cff

ypatil12 approved these changes Jan 22, 2026

View reviewed changes

serichoi65 merged commit f995246 into master Jan 22, 2026
18 checks passed

serichoi65 deleted the rewards-v2.2-tests branch January 22, 2026 18:55

chore: add rewards v2.2 comprehensive unit/integration/Anvil tests #490

chore: add rewards v2.2 comprehensive unit/integration/Anvil tests #490

Uh oh!

Conversation

serichoi65 commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Summary

Test Coverage

Bug Fixes & Improvements

Notes

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anupsv Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

serichoi65 Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ypatil12 Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

serichoi65 commented Jan 6, 2026 •

edited

Loading