Skip to content

feat(lwd,lwm): removed llMevProtection feature flag, updated i18n fil… #13510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iqbalibrahim-ledger merged 3 commits into from
Jan 13, 2026
Merged

feat(lwd,lwm): removed llMevProtection feature flag, updated i18n fil… #13510

iqbalibrahim-ledger merged 3 commits into from
Jan 13, 2026

Conversation

@iqbalibrahim-ledger
Copy link
Contributor

@iqbalibrahim-ledger iqbalibrahim-ledger commented Dec 31, 2025 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • removed the llMevProtection feature flag
    • updated URL config files to include MEV protection link

📝 Description

Removal of the llMevProtection feature flag; added MEV protection link in i18n files (desktop and mobile)

❓ Context

LIVE-23913

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel
Copy link

vercel bot commented Dec 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments
Project Deployment Review Updated (UTC)
ledger-live-github-bot Ignored Ignored Preview Jan 8, 2026 3:34pm
native-ui-storybook Ignored Ignored Preview Jan 8, 2026 3:34pm
react-ui-storybook Ignored Ignored Preview Jan 8, 2026 3:34pm
web-tools Ignored Ignored Preview Jan 8, 2026 3:34pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched labels Dec 31, 2025
LucasWerey
LucasWerey reviewed Dec 31, 2025
View reviewed changes
apps/ledger-live-mobile/src/locales/zh/common.json Outdated
"mevProtection" : "MEV 保护",
"mevProtectionDesc" : "启用 MEV Protection，确保以太坊上的交易更加可靠。",
"mevProtectionLearnMore" : "隐私声明",
"mevProtectionLearnMoreUrl": "https://support.ledger.com/zh-CN/article/How-to-protect-your-transactions-from-Maximal-Extractable-Value-MEV-attacks",
Copy link
Member

@LucasWerey LucasWerey Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

urls have their own files urls for LWM and LWD. You don't need to localize them. So basically you can add https://support.ledger.com/article/How-to-protect-your-transactions-from-Maximal-Extractable-Value-MEV-attacks in the urls files, then localize it with useLocalizedUrl hook

Copy link
Contributor Author

@iqbalibrahim-ledger iqbalibrahim-ledger Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LucasWerey thanks for letting me know, I've made these changes now

@live-github-bot live-github-bot bot removed the translations Translation files have been touched label Jan 8, 2026
@iqbalibrahim-ledger iqbalibrahim-ledger marked this pull request as ready for review January 8, 2026 11:56
@iqbalibrahim-ledger iqbalibrahim-ledger requested a review from a team as a code owner January 8, 2026 11:56
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026 •
edited
Loading

⚠️ E2E tests are required

Changes detected require e2e testing before merge (even before asking for any review).

🖥️ Desktop

-> Run Desktop E2E

  • Select "Run workflow"
  • Branch: feat/LIVE-23913
  • Device: nanoSP or stax

📱 Mobile

-> Run Mobile E2E

  • Select "Run workflow"
  • Branch: feat/LIVE-23913
  • Device: nanoX

@iqbalibrahim-ledger iqbalibrahim-ledger force-pushed the feat/LIVE-23913 branch 2 times, most recently from fd8d618 to cad7b1c Compare January 8, 2026 13:48
LucasWerey
LucasWerey previously approved these changes Jan 8, 2026
View reviewed changes
@iqbalibrahim-ledger
Copy link
Contributor Author

iqbalibrahim-ledger commented Jan 8, 2026 •
edited by live-github-bot bot
Loading

@iqbalibrahim-ledger

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux

@live-github-bot live-github-bot bot added the screenshots Screenshots have been updated label Jan 8, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
27.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@live-github-bot
Copy link
Contributor

live-github-bot bot commented Jan 12, 2026

Desktop Bundle Checks

Comparing 0f7393f against 3c19a9a.

🚀 renderer bundle size decreased (24.9mb -> 24.7mb). Thanks ❤️
🚀 @ethersproject/signing-key library is no longer duplicated in renderer
🚀 @ethersproject/transactions library is no longer duplicated in renderer

@iqbalibrahim-ledger
Copy link
Contributor Author

iqbalibrahim-ledger commented Jan 12, 2026

Merging without QA as suggested by @KVNLS - will be tested at release.

@iqbalibrahim-ledger iqbalibrahim-ledger merged commit fec32da into develop Jan 13, 2026
155 of 160 checks passed
@iqbalibrahim-ledger iqbalibrahim-ledger deleted the feat/LIVE-23913 branch January 13, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LucasWerey LucasWerey LucasWerey approved these changes

Assignees

@iqbalibrahim-ledger iqbalibrahim-ledger

Labels

common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM screenshots Screenshots have been updated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iqbalibrahim-ledger @LucasWerey