Skip to content

feat: make HTTP client metrics optional #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnicoulaud-ledger merged 1 commit into from
Apr 29, 2025
Merged

feat: make HTTP client metrics optional #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions modules/http-client/src/main/scala/pillars/httpclient/httpclient.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ object HttpClient extends ModuleSupport:
for
_ <- Resource.eval(logger.info("Loading HTTP client module"))
conf <- Resource.eval(reader.read[HttpClient.Config]("http-client"))
metrics <- ClientMetrics(observability).toResource
metrics <- if conf.metrics then ClientMetrics(observability).map(_.middleware).toResource
else Resource.pure(identity[Client[IO]])
client <- NettyClientBuilder[IO]
.withHttp2
.withNioTransport
Expand All @@ -119,7 +120,7 @@ object HttpClient extends ModuleSupport:
val followRedirect =
if conf.followRedirect then FollowRedirect[IO](10) else identity[Client[IO]]
client
|> metrics.middleware
|> metrics
|> logging
|> followRedirect
|> HttpClient(conf)
Expand All @@ -132,7 +133,8 @@ object HttpClient extends ModuleSupport:
maxConnections: Int = 10,
followRedirect: Boolean = true,
userAgent: `User-Agent` = Config.defaultUserAgent,
logging: Logging.HttpConfig = Logging.HttpConfig()
logging: Logging.HttpConfig = Logging.HttpConfig(),
metrics: Boolean = true
) extends pillars.Config

object Config:
Expand Down