Skip to content

fix: ensure proper cleanup of processes in wrap_litserve_start#432

Merged
aniketmaurya merged 1 commit intoLightning-AI:mainfrom
bhimrazy:fix/wrap_litserve_start
Feb 18, 2025
Merged

fix: ensure proper cleanup of processes in wrap_litserve_start#432
aniketmaurya merged 1 commit intoLightning-AI:mainfrom
bhimrazy:fix/wrap_litserve_start

Conversation

@bhimrazy
Copy link
Copy Markdown
Collaborator

@bhimrazy bhimrazy commented Feb 18, 2025

What does this PR do?

This PR implements proper cleanup of processes initiated by wrap_litserve_start, ensuring that test cases using this function exit gracefully upon completion.

Fixes #431

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89%. Comparing base (49cedbd) to head (6c0aff8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #432   +/-   ##
===================================
  Coverage    89%    89%           
===================================
  Files        31     31           
  Lines      2025   2027    +2     
===================================
+ Hits       1806   1813    +7     
+ Misses      219    214    -5     

Copy link
Copy Markdown
Collaborator

@aniketmaurya aniketmaurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @bhimrazy 🚀

@aniketmaurya aniketmaurya merged commit 72655ce into Lightning-AI:main Feb 18, 2025
20 of 21 checks passed
@bhimrazy bhimrazy deleted the fix/wrap_litserve_start branch February 18, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing tests with wrap_litserve_start Never exit

2 participants