Skip to content

fix: remove warnings for Streaming Dataset with hf dataset and shuffle enabled#520

Merged
tchaton merged 1 commit intoLightning-AI:mainfrom
bhimrazy:cleanup-warning
Mar 20, 2025
Merged

fix: remove warnings for Streaming Dataset with hf dataset and shuffle enabled#520
tchaton merged 1 commit intoLightning-AI:mainfrom
bhimrazy:cleanup-warning

Conversation

@bhimrazy
Copy link
Collaborator

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Removes warnings for Streaming Dataset with hf dataset and shuffle enabled which was added in #505

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@bhimrazy bhimrazy marked this pull request as ready for review March 20, 2025 08:26
@codecov
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79%. Comparing base (6e4a409) to head (459a0ac).
Report is 2 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #520   +/-   ##
===================================
- Coverage    79%    79%   -0%     
===================================
  Files        39     39           
  Lines      5887   5885    -2     
===================================
- Hits       4648   4646    -2     
  Misses     1239   1239           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tchaton tchaton merged commit e37a524 into Lightning-AI:main Mar 20, 2025
36 checks passed
@bhimrazy bhimrazy deleted the cleanup-warning branch March 20, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants