Skip to content

fix: remove warnings for Streaming Dataset with hf dataset and shuffle enabled #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tchaton merged 1 commit into from
Mar 20, 2025
Merged

fix: remove warnings for Streaming Dataset with hf dataset and shuffle enabled #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/litdata/streaming/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,6 @@ def __init__(
"Please provide a valid ParquetLoader instance."
)

if item_loader is not None and item_loader._low_memory and shuffle:
raise ValueError(
"You have enabled shuffling when using low memory with ParquetLoader. "
"This configuration may lead to performance issues during the training process. "
"Consider disabling shuffling or using a ParquetLoader without low memory mode."
)
item_loader = item_loader or ParquetLoader()

self.input_dir = input_dir
Expand Down
4 changes: 0 additions & 4 deletions tests/streaming/test_parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,3 @@ def test_stream_hf_parquet_dataset(monkeypatch, huggingface_hub_fs_mock, pq_data
assert _ds[0] == pq_data["name"][idx]
assert _ds[1] == pq_data["weight"][idx]
assert _ds[2] == pq_data["height"][idx]

# Test case 5: Streaming with ParquetLoader and low_memory=True and shuffle=True
with pytest.raises(ValueError, match="You have enabled shuffling when using low memory with ParquetLoader."):
StreamingDataset(hf_url, item_loader=ParquetLoader(low_memory=True), shuffle=True)
Loading